Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Unified Diff: chrome/common/extensions/api/downloads.idl

Issue 1706193002: Expose final download URL (actual url after redirects) in the extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/downloads.idl
diff --git a/chrome/common/extensions/api/downloads.idl b/chrome/common/extensions/api/downloads.idl
index 95802fc58f8dd848432af247b7d141f3e66570f2..6e8c211084e0371a8b1a8fa9da09283f657ce232 100644
--- a/chrome/common/extensions/api/downloads.idl
+++ b/chrome/common/extensions/api/downloads.idl
@@ -133,9 +133,14 @@ namespace downloads {
long id;
// Absolute URL.
+ // URL that this download started from (before any redirects).
DOMString url;
// Absolute URL.
+ // Actual download URL (final url in chain after all redirects).
+ DOMString finalUrl;
+
+ // Absolute URL.
DOMString referrer;
// Absolute local path.
@@ -261,6 +266,10 @@ namespace downloads {
// <code>url</code> matches the given regular expression.
DOMString? urlRegex;
+ // Limits results to $(ref:DownloadItem) whose
+ // <code>finalUrl</code> matches the given regular expression.
+ DOMString? finalUrlRegex;
+
// The maximum number of matching $(ref:DownloadItem) returned. Defaults to
// 1000. Set to 0 in order to return all matching $(ref:DownloadItem). See
// $(ref:search) for how to page through results.
@@ -277,8 +286,13 @@ namespace downloads {
long? id;
// Absolute URL.
+ // URL that this download started from (before any redirects).
DOMString? url;
+ // Absolute URL.
+ // Actual download URL (final url in chain after all redirects).
+ DOMString? finalUrl;
+
// Absolute local path.
DOMString? filename;
@@ -344,6 +358,9 @@ namespace downloads {
// The change in <code>url</code>, if any.
StringDelta? url;
+ // The change in <code>finalUrl</code>, if any.
+ StringDelta? finalUrl;
+
// The change in <code>filename</code>, if any.
StringDelta? filename;

Powered by Google App Engine
This is Rietveld 408576698