Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2034)

Unified Diff: base/task_scheduler/scheduler_lock.h

Issue 1706123002: TaskScheduler [2/9] Scheduler Lock (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/scheduler_lock.h
diff --git a/base/task_scheduler/scheduler_lock.h b/base/task_scheduler/scheduler_lock.h
new file mode 100644
index 0000000000000000000000000000000000000000..639def31dd02b0106c00968d2baebe9673f60b0f
--- /dev/null
+++ b/base/task_scheduler/scheduler_lock.h
@@ -0,0 +1,58 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BASE_TASK_SCHEDULER_SCHEDULER_LOCK_H
+#define BASE_TASK_SCHEDULER_SCHEDULER_LOCK_H
+
+#include <vector>
+
+#include "base/base_export.h"
+#include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/synchronization/condition_variable.h"
+#include "base/synchronization/lock.h"
+#include "base/task_scheduler/scheduler_lock_impl.h"
+
+namespace base {
+namespace internal {
+
gab 2016/02/18 16:58:06 Add a meta comment here on how this class should b
robliao 2016/02/18 21:59:36 Done, except for the loops part. The unit tests ac
+#if DCHECK_IS_ON()
+class SchedulerLock : public SchedulerLockImpl {
+ public:
+ SchedulerLock() = default;
+ explicit SchedulerLock(const SchedulerLock* predecessor)
+ : SchedulerLockImpl(predecessor) {}
+};
+#else
gab 2016/02/18 16:58:06 #else // DCHECK_IS_ON()
robliao 2016/02/18 21:59:36 Done.
+class SchedulerLock : public Lock {
+ public:
+ SchedulerLock() = default;
+ explicit SchedulerLock(const SchedulerLock*) {}
+
+ // Functionally equivalent to SchedulerLockImpl::CreateConditionVariable.
+ scoped_ptr<ConditionVariable> CreateConditionVariable() {
+ return scoped_ptr<ConditionVariable>(new ConditionVariable(this));
+ }
+};
+#endif
gab 2016/02/18 16:58:06 #endif // DCHECK_IS_ON()
robliao 2016/02/18 21:59:36 Done.
+
+class AutoSchedulerLock {
+ public:
+ explicit AutoSchedulerLock(SchedulerLock& lock) : lock_(lock) {
+ lock_.Acquire();
+ }
+
+ ~AutoSchedulerLock() {
+ lock_.Release();
gab 2016/02/18 16:58:06 Add lock_.AssertAcquired(); above. (to match Au
robliao 2016/02/18 21:59:36 Done.
+ }
+
+ private:
+ SchedulerLock& lock_;
+ DISALLOW_COPY_AND_ASSIGN(AutoSchedulerLock);
gab 2016/02/18 16:58:06 Chromium style is typically to have an empty line
robliao 2016/02/18 21:59:36 Done.
+};
+
+} // namespace internal
+} // namespace base
+
+#endif // BASE_TASK_SCHEDULER_SCHEDULER_LOCK_H

Powered by Google App Engine
This is Rietveld 408576698