Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 17061004: Deprecate old code aging mechanism. (Closed)

Created:
7 years, 6 months ago by Michael Starzinger
Modified:
7 years, 6 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Deprecate old code aging mechanism. The old code aging mechanism is too agressive with flushing as it leads to many functions being flushed and recompiled over and over again. By now the new code aging mechanism has stabilized enough to deprecate the old fallback mechanism. R=danno@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15209

Patch Set 1 #

Patch Set 2 : Bring lost comment back. #

Total comments: 2

Patch Set 3 : Addressed comment by Daniel Clifford. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -46 lines) Patch
M src/compiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 2 3 chunks +5 lines, -14 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/objects-visiting-inl.h View 2 chunks +5 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
7 years, 6 months ago (2013-06-14 14:44:08 UTC) #1
danno
lgtm with nit https://codereview.chromium.org/17061004/diff/3001/src/objects.h File src/objects.h (right): https://codereview.chromium.org/17061004/diff/3001/src/objects.h#newcode4825 src/objects.h:4825: // relatively safe to flush this ...
7 years, 6 months ago (2013-06-14 18:40:08 UTC) #2
Michael Starzinger
Addressed comments. Landing. https://codereview.chromium.org/17061004/diff/3001/src/objects.h File src/objects.h (right): https://codereview.chromium.org/17061004/diff/3001/src/objects.h#newcode4825 src/objects.h:4825: // relatively safe to flush this ...
7 years, 6 months ago (2013-06-18 15:35:15 UTC) #3
Michael Starzinger
7 years, 6 months ago (2013-06-19 17:00:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r15209 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698