Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: third_party/WebKit/Source/core/fetch/RawResourceTest.cpp

Issue 1706083002: Split ImageResourceClient into ResourceClient and ImageResourceObserver [1/2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/RawResourceTest.cpp
diff --git a/third_party/WebKit/Source/core/fetch/RawResourceTest.cpp b/third_party/WebKit/Source/core/fetch/RawResourceTest.cpp
index 94966749b039fbf9da33907fcf0fa2aecc69adf4..1b7aab251e979a7a368314ac6826f7913e681b52 100644
--- a/third_party/WebKit/Source/core/fetch/RawResourceTest.cpp
+++ b/third_party/WebKit/Source/core/fetch/RawResourceTest.cpp
@@ -30,9 +30,7 @@
#include "core/fetch/RawResource.h"
-#include "core/fetch/ImageResourceClient.h"
#include "core/fetch/MemoryCache.h"
-#include "core/fetch/MockImageResourceClient.h"
#include "core/fetch/ResourceFetcher.h"
#include "platform/SharedBuffer.h"
#include "platform/testing/UnitTestHelpers.h"
@@ -138,7 +136,7 @@ TEST(RawResourceTest, RevalidationSucceeded)
memoryCache()->remove(resource.get());
resource->removeClient(client.get());
- EXPECT_FALSE(resource->hasClients());
+ EXPECT_FALSE(resource->hasClientsOrObservers());
EXPECT_FALSE(client->called());
EXPECT_EQ("abcd", String(client->data().data(), client->data().size()));
}
@@ -168,7 +166,7 @@ TEST(RawResourceTest, RevalidationSucceededForResourceWithoutBody)
memoryCache()->remove(resource.get());
resource->removeClient(client.get());
- EXPECT_FALSE(resource->hasClients());
+ EXPECT_FALSE(resource->hasClientsOrObservers());
EXPECT_FALSE(client->called());
EXPECT_EQ(0u, client->data().size());
}
@@ -190,7 +188,7 @@ TEST(RawResourceTest, AddClientDuringCallback)
testing::runPendingTasks();
raw->removeClient(addingClient.get());
EXPECT_FALSE(dummyClient->called());
- EXPECT_FALSE(raw->hasClients());
+ EXPECT_FALSE(raw->hasClientsOrObservers());
}
// This client removes another client when notified.
@@ -228,7 +226,7 @@ TEST(RawResourceTest, RemoveClientDuringCallback)
raw->addClient(dummyClient.get());
raw->addClient(removingClient.get());
testing::runPendingTasks();
- EXPECT_FALSE(raw->hasClients());
+ EXPECT_FALSE(raw->hasClientsOrObservers());
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/fetch/RawResource.cpp ('k') | third_party/WebKit/Source/core/fetch/Resource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698