Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1816)

Unified Diff: Source/core/svg/properties/SVGListProperty.h

Issue 170603003: Use nullptr_t for RefPtr, PassRefPtr and RawPtr. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Final rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/properties/SVGAnimatedListPropertyTearOff.h ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/properties/SVGListProperty.h
diff --git a/Source/core/svg/properties/SVGListProperty.h b/Source/core/svg/properties/SVGListProperty.h
index f524be4a830e95ee403f31110d1b672453a2df85..9eb95ad0d17f83b8269a41e3fc8f3a19c76f9e84 100644
--- a/Source/core/svg/properties/SVGListProperty.h
+++ b/Source/core/svg/properties/SVGListProperty.h
@@ -64,7 +64,7 @@ public:
// Reinitialize the wrapper cache to be equal to the new values size, after the XML DOM changed the list.
if (newListSize)
- wrappers->fill(0, newListSize);
+ wrappers->fill(nullptr, newListSize);
else
wrappers->clear();
}
@@ -136,12 +136,12 @@ public:
{
ASSERT(m_wrappers);
if (!canAlterList(exceptionState))
- return 0;
+ return nullptr;
// Not specified, but FF/Opera do it this way, and it's just sane.
if (!passNewItem) {
exceptionState.throwTypeError("The PassListItemType provided is invalid.");
- return 0;
+ return nullptr;
}
RefPtr<ListItemTearOff> newItem = passNewItem;
@@ -185,7 +185,7 @@ public:
{
ASSERT(m_wrappers);
if (!canGetItem(index, exceptionState))
- return 0;
+ return nullptr;
// Spec: Returns the specified item from the list. The returned item is the item itself and not a copy.
// Any changes made to the item are immediately reflected in the list.
@@ -230,12 +230,12 @@ public:
{
ASSERT(m_wrappers);
if (!canAlterList(exceptionState))
- return 0;
+ return nullptr;
// Not specified, but FF/Opera do it this way, and it's just sane.
if (!passNewItem) {
exceptionState.throwTypeError("The PassListItemType provided is invalid.");
- return 0;
+ return nullptr;
}
// Spec: If the index is greater than or equal to numberOfItems, then the new item is appended to the end of the list.
@@ -303,12 +303,12 @@ public:
{
ASSERT(m_wrappers);
if (!canReplaceItem(index, exceptionState))
- return 0;
+ return nullptr;
// Not specified, but FF/Opera do it this way, and it's just sane.
if (!passNewItem) {
exceptionState.throwTypeError("The PassListItemType provided is invalid.");
- return 0;
+ return nullptr;
}
ASSERT(m_values->size() == m_wrappers->size());
@@ -323,7 +323,7 @@ public:
ASSERT(m_wrappers->isEmpty());
// 'passNewItem' already lived in our list, we removed it, and now we're empty, which means there's nothing to replace.
exceptionState.throwDOMException(IndexSizeError, "The new item lived in this list, and has been removed.");
- return 0;
+ return nullptr;
}
// Detach the existing wrapper.
@@ -369,7 +369,7 @@ public:
{
ASSERT(m_wrappers);
if (!canRemoveItem(index, exceptionState))
- return 0;
+ return nullptr;
ASSERT(m_values->size() == m_wrappers->size());
@@ -406,12 +406,12 @@ public:
{
ASSERT(m_wrappers);
if (!canAlterList(exceptionState))
- return 0;
+ return nullptr;
// Not specified, but FF/Opera do it this way, and it's just sane.
if (!passNewItem) {
exceptionState.throwTypeError("The PassListItemType provided is invalid.");
- return 0;
+ return nullptr;
}
RefPtr<ListItemTearOff> newItem = passNewItem;
« no previous file with comments | « Source/core/svg/properties/SVGAnimatedListPropertyTearOff.h ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698