Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: Source/web/WebIDBKeyRange.cpp

Issue 170603003: Use nullptr_t for RefPtr, PassRefPtr and RawPtr. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Final rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/web/WebIDBKey.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 23 matching lines...) Expand all
34 34
35 namespace blink { 35 namespace blink {
36 36
37 void WebIDBKeyRange::assign(const WebIDBKeyRange& other) 37 void WebIDBKeyRange::assign(const WebIDBKeyRange& other)
38 { 38 {
39 m_private = other.m_private; 39 m_private = other.m_private;
40 } 40 }
41 41
42 void WebIDBKeyRange::assign(const WebIDBKey& lower, const WebIDBKey& upper, bool lowerOpen, bool upperOpen) 42 void WebIDBKeyRange::assign(const WebIDBKey& lower, const WebIDBKey& upper, bool lowerOpen, bool upperOpen)
43 { 43 {
44 // FIXME: replace reset() with nullptr assignment (cf. https://codereview.ch romium.org/170603003/ )
45 if (!lower.isValid() && !upper.isValid()) 44 if (!lower.isValid() && !upper.isValid())
46 m_private.reset(); 45 m_private.reset();
47 else 46 else
48 m_private = IDBKeyRange::create(lower, upper, lowerOpen ? IDBKeyRange::L owerBoundOpen : IDBKeyRange::LowerBoundClosed, upperOpen ? IDBKeyRange::UpperBou ndOpen : IDBKeyRange::UpperBoundClosed); 47 m_private = IDBKeyRange::create(lower, upper, lowerOpen ? IDBKeyRange::L owerBoundOpen : IDBKeyRange::LowerBoundClosed, upperOpen ? IDBKeyRange::UpperBou ndOpen : IDBKeyRange::UpperBoundClosed);
49 } 48 }
50 49
51 void WebIDBKeyRange::reset() 50 void WebIDBKeyRange::reset()
52 { 51 {
53 m_private.reset(); 52 m_private.reset();
54 } 53 }
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 m_private = value; 86 m_private = value;
88 return *this; 87 return *this;
89 } 88 }
90 89
91 WebIDBKeyRange::operator PassRefPtr<IDBKeyRange>() const 90 WebIDBKeyRange::operator PassRefPtr<IDBKeyRange>() const
92 { 91 {
93 return m_private.get(); 92 return m_private.get();
94 } 93 }
95 94
96 } // namespace blink 95 } // namespace blink
OLDNEW
« no previous file with comments | « Source/web/WebIDBKey.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698