Moving the validation of bitstream_buffer into VDA implementations.

content/common/gpu/media/fake_video_decode_accelerator.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/media/fake_video_decode_accelerator.h"
 
 #include <stddef.h>
 #include <string.h>
 
 #include "base/bind.h"
@@ skipping 49 matching lines @@
   // This class asks for it on initialization instead.
   client_ = client;
   client_->ProvidePictureBuffers(kNumBuffers,
                                  frame_buffer_size_,
                                  kDefaultTextureTarget);
   return true;
 }
 
 void FakeVideoDecodeAccelerator::Decode(
     const media::BitstreamBuffer& bitstream_buffer) {
+  // We won't really read from the bitstream_buffer, close the handle.
+  if (base::SharedMemory::IsHandleValid(bitstream_buffer.handle()))
+    base::SharedMemory::CloseHandle(bitstream_buffer.handle());
+
+  if (bitstream_buffer.id() < 0) {
+    LOG(ERROR) << "Invalid bitstream: id=" << bitstream_buffer.id();
+    client_->NotifyError(INVALID_ARGUMENT);
+    return;
+  }
+
   int bitstream_buffer_id = bitstream_buffer.id();
   queued_bitstream_ids_.push(bitstream_buffer_id);
   child_task_runner_->PostTask(
       FROM_HERE, base::Bind(&FakeVideoDecodeAccelerator::DoPictureReady,
                             weak_this_factory_.GetWeakPtr()));
 }
 
 // Similar to UseOutputBitstreamBuffer for the encode accelerator.
 void FakeVideoDecodeAccelerator::AssignPictureBuffers(
     const std::vector<media::PictureBuffer>& buffers) {
@@ skipping 96 matching lines @@
     // Bitstream no longer needed.
     client_->NotifyEndOfBitstreamBuffer(bitstream_id);
     if (flushing_ && queued_bitstream_ids_.empty()) {
       flushing_ = false;
       client_->NotifyFlushDone();
     }
   }
 }
 
 }  // namespace content