Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Issue 1705953002: Revert of Generate compiled_resources2.gyp for Polymer based on <link rel=import>s (Closed)

Created:
4 years, 10 months ago by sky
Modified:
4 years, 10 months ago
Reviewers:
Dan Beam, michaelpg, dpapad
CC:
chromium-reviews, dbeam+watch-closure_chromium.org, dcheng, jlklein+watch-closure_chromium.org, michaelpg+watch-polymer_chromium.org, vitalyp+closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Generate compiled_resources2.gyp for Polymer based on <link rel=import>s (patchset #6 id:180001 of https://codereview.chromium.org/1702553002/ ) Reason for revert: This broke checklicenses: 'third_party/polymer/v1_0/generate_gyp.sh' has non-whitelisted license 'UNKNOWN' Original issue's description: > Generate compiled_resources2.gyp for Polymer based on <link rel=import>s > > This CL aims to generate GYP output from the imports listed > in each HTML file in Polymer to Closure Compile the code. > > R=dpapad@chromium.org,michaelpg@chromium.org > BUG=none > NOTRY=true > > Committed: https://crrev.com/e91f8875e590ddf00af267062fc1a9ec48658373 > Cr-Commit-Position: refs/heads/master@{#375953} TBR=dpapad@chromium.org,michaelpg@chromium.org,dbeam@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1496 lines) Patch
D third_party/polymer/v1_0/components-chromium/font-roboto/compiled_resources2.gyp View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/compiled_resources2.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-a11y-keys/compiled_resources2.gyp View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/compiled_resources2.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-behaviors/compiled_resources2.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-checked-element-behavior/compiled_resources2.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-collapse/compiled_resources2.gyp View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-dropdown/compiled_resources2.gyp View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-fit-behavior/compiled_resources2.gyp View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-flex-layout/classes/compiled_resources2.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-flex-layout/compiled_resources2.gyp View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-form-element-behavior/compiled_resources2.gyp View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-icon/compiled_resources2.gyp View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-icons/compiled_resources2.gyp View 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-iconset-svg/compiled_resources2.gyp View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-image/compiled_resources2.gyp View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-input/compiled_resources2.gyp View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/compiled_resources2.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-media-query/compiled_resources2.gyp View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-menu-behavior/compiled_resources2.gyp View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-meta/compiled_resources2.gyp View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/compiled_resources2.gyp View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-pages/compiled_resources2.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-range-behavior/compiled_resources2.gyp View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-resizable-behavior/compiled_resources2.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-scroll-target-behavior/compiled_resources2.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-selector/compiled_resources2.gyp View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-test-helpers/compiled_resources2.gyp View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-validatable-behavior/compiled_resources2.gyp View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/neon-animation/animations/compiled_resources2.gyp View 1 chunk +0 lines, -135 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/neon-animation/compiled_resources2.gyp View 1 chunk +0 lines, -104 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/neon-animation/guides/compiled_resources2.gyp View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-behaviors/compiled_resources2.gyp View 2 chunks +2 lines, -18 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-button/compiled_resources2.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-card/compiled_resources2.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-checkbox/compiled_resources2.gyp View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/compiled_resources2.gyp View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dialog/compiled_resources2.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-drawer-panel/compiled_resources2.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/compiled_resources2.gyp View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-fab/compiled_resources2.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-header-panel/compiled_resources2.gyp View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-icon-button/compiled_resources2.gyp View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-input/compiled_resources2.gyp View 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-item/compiled_resources2.gyp View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-material/compiled_resources2.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-menu-button/compiled_resources2.gyp View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-menu/compiled_resources2.gyp View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-progress/compiled_resources2.gyp View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-radio-button/compiled_resources2.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-radio-group/compiled_resources2.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-ripple/compiled_resources2.gyp View 1 chunk +2 lines, -4 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-slider/compiled_resources2.gyp View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-spinner/compiled_resources2.gyp View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-styles/classes/compiled_resources2.gyp View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-styles/compiled_resources2.gyp View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-tabs/compiled_resources2.gyp View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-toggle-button/compiled_resources2.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-toolbar/compiled_resources2.gyp View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-tooltip/compiled_resources2.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/polymer/v1_0/generate_gyp.sh View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/polymer/v1_0/reproduce.sh View 2 chunks +0 lines, -3 lines 0 comments Download
D tools/polymer/generate_compiled_resources_gyp.py View 1 chunk +0 lines, -77 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
Created Revert of Generate compiled_resources2.gyp for Polymer based on <link rel=import>s
4 years, 10 months ago (2016-02-17 20:36:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705953002/1
4 years, 10 months ago (2016-02-17 20:38:03 UTC) #2
commit-bot: I haz the power
Failed to apply patch for third_party/polymer/v1_0/components-chromium/neon-animation/guides/compiled_resources2.gyp: While running git apply --index -3 -p1; fatal: unrecognized ...
4 years, 10 months ago (2016-02-17 20:40:54 UTC) #4
dpapad
lgtm
4 years, 10 months ago (2016-02-17 21:08:08 UTC) #6
Dan Beam
4 years, 10 months ago (2016-02-17 22:17:17 UTC) #7
can I just add a license to generate_gyp.sh?

Powered by Google App Engine
This is Rietveld 408576698