Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 17059002: Revert 206237 "Menu for the OSX app launcher, HoverImageMenuButt..." (Closed)

Created:
7 years, 6 months ago by tapted
Modified:
7 years, 6 months ago
Reviewers:
tapted
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 206237 "Menu for the OSX app launcher, HoverImageMenuButt..." Causes memory leaks in AppKit due to some obscure codepaths. BUG=249630 > Menu for the OSX app launcher, HoverImageMenuButton in src/ui/base/cocoa/controls. > > Adds a drop-down menu to the right of the search entry area on the OSX > app launcher. The menu is shown when clicked, and the button responds to > hover effects. > > The menu button uses a new class, HoverImageMenuButton, which is derived > from an NSPopUpButton with minor extensions. Notably, it does not have a > dependency on browser themes, as does MenuButton from > chrome/browser/ui/cocoa. It tracks the mouse hover state and updates > the cell, which extends NSPopUpButtonCell and shows only the image in > the control frame -- no border, bezel, label, or dropdown arrow. > > HoverImageMenuButtonCell supports a hover image, which behaves much like > an additional 'alternateImage' from NSButtonCell but for the hover > state, rather than the 'pressed' (or 'lit') state. > > The menu shows the currently signed-in user, in a custom view as the > first item. It also (currently) shows menu options for Settings, Help, and > Feedback. > > BUG=138633 > TEST=Added app_list_unittests AppsSearchBoxMenuTest and > AppsSearchBoxMenuTest and tested manually to ensure the items are > launched correctly. Added ui_unittests HoverImageMenuButtonTest.* > > Review URL: https://chromiumcodereview.appspot.com/15955003 TBR=tapted@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206375

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -643 lines) Patch
M trunk/src/build/common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/ui/app_list/app_list.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/ui/app_list/app_list_menu.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ui/app_list/cocoa/app_list_view_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ui/app_list/cocoa/app_list_view_controller.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/ui/app_list/cocoa/apps_search_box_controller.h View 3 chunks +0 lines, -10 lines 0 comments Download
M trunk/src/ui/app_list/cocoa/apps_search_box_controller.mm View 5 chunks +3 lines, -104 lines 0 comments Download
M trunk/src/ui/app_list/cocoa/apps_search_box_controller_unittest.mm View 3 chunks +0 lines, -64 lines 0 comments Download
D trunk/src/ui/app_list/cocoa/current_user_menu_item_view.h View 1 chunk +0 lines, -24 lines 0 comments Download
D trunk/src/ui/app_list/cocoa/current_user_menu_item_view.mm View 1 chunk +0 lines, -85 lines 0 comments Download
D trunk/src/ui/base/cocoa/controls/hover_image_menu_button.h View 1 chunk +0 lines, -29 lines 0 comments Download
D trunk/src/ui/base/cocoa/controls/hover_image_menu_button.mm View 1 chunk +0 lines, -44 lines 0 comments Download
D trunk/src/ui/base/cocoa/controls/hover_image_menu_button_cell.h View 1 chunk +0 lines, -32 lines 0 comments Download
D trunk/src/ui/base/cocoa/controls/hover_image_menu_button_cell.mm View 1 chunk +0 lines, -69 lines 0 comments Download
D trunk/src/ui/base/cocoa/controls/hover_image_menu_button_unittest.mm View 1 chunk +0 lines, -168 lines 0 comments Download
M trunk/src/ui/ui.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/ui/ui_unittests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tapted
7 years, 6 months ago (2013-06-14 09:02:59 UTC) #1
tapted
7 years, 6 months ago (2013-06-14 09:04:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r206375.

Powered by Google App Engine
This is Rietveld 408576698