Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1705883002: Run mojo_apptests on debug Linux as well. (Closed)

Created:
4 years, 10 months ago by jam
Modified:
4 years, 10 months ago
Reviewers:
msw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run mojo_apptests on debug Linux as well. Any test which runs on the main waterfall should run on debug and release. Otherwise a dcheck could be hit which wouldn't show up on the main waterfall, but would fail on the trybots which use release-with-asserts. BUG=478244 Committed: https://crrev.com/a7cef43c8ed1c379bd2d6bb5fffd3a7ff2a38fb0 Cr-Commit-Position: refs/heads/master@{#376028}

Patch Set 1 #

Patch Set 2 : remove linux32 since it's using gyp and apptests require gn #

Patch Set 3 : build media mojo code for component builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M media/mojo/services/BUILD.gn View 1 2 1 chunk +3 lines, -11 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
jam
4 years, 10 months ago (2016-02-17 19:01:00 UTC) #2
msw
Nice, lgtm. maybe these were GYP bots when I originally added the step to the ...
4 years, 10 months ago (2016-02-17 19:07:39 UTC) #3
msw
Also, you can use BUG=478244
4 years, 10 months ago (2016-02-17 19:08:54 UTC) #4
jam
On 2016/02/17 19:07:39, msw wrote: > Nice, lgtm. maybe these were GYP bots when I ...
4 years, 10 months ago (2016-02-17 19:09:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705883002/40001
4 years, 10 months ago (2016-02-17 21:25:26 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/182489)
4 years, 10 months ago (2016-02-17 22:42:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705883002/40001
4 years, 10 months ago (2016-02-17 22:55:22 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-17 23:27:50 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 23:28:54 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a7cef43c8ed1c379bd2d6bb5fffd3a7ff2a38fb0
Cr-Commit-Position: refs/heads/master@{#376028}

Powered by Google App Engine
This is Rietveld 408576698