Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1705863002: [SPv2] Remove PaintArtifactCompositor::initializeIfNeeded. (Closed)

Created:
4 years, 10 months ago by jbroman
Modified:
4 years, 10 months ago
Reviewers:
pdr.
CC:
jbroman, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SPv2] Remove PaintArtifactCompositor::initializeIfNeeded. Now that we can guarantee the RuntimeEnabledFeatures is initialized in the constructor, it seems like a cleaner place to put this kind of mandatory initialization logic. The only caveat is that the constructor will be called when SPv2 is off, but that's easily handled by changing an assert to a conditional return. BUG=563667 Committed: https://crrev.com/e502046d370b3f3c77e91dab787c97e21ff9c27d Cr-Commit-Position: refs/heads/master@{#376349}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -22 lines) Patch
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 1 chunk +4 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp View 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImplPaintArtifactCompositorTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
jbroman
not important, but I forgot to fully kill the two-phase initialization in this class, so ...
4 years, 10 months ago (2016-02-17 19:10:32 UTC) #2
pdr.
On 2016/02/17 at 19:10:32, jbroman wrote: > not important, but I forgot to fully kill ...
4 years, 10 months ago (2016-02-18 21:20:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705863002/1
4 years, 10 months ago (2016-02-18 21:28:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/52107)
4 years, 10 months ago (2016-02-18 21:51:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705863002/1
4 years, 10 months ago (2016-02-18 22:20:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/175976)
4 years, 10 months ago (2016-02-19 01:14:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705863002/1
4 years, 10 months ago (2016-02-19 01:38:29 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 02:40:25 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 02:41:16 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e502046d370b3f3c77e91dab787c97e21ff9c27d
Cr-Commit-Position: refs/heads/master@{#376349}

Powered by Google App Engine
This is Rietveld 408576698