Issue 170583002: Refactor persisting state in push and merge scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 170583002: Refactor persisting state in push and merge scripts. (Closed)

Created:
6 years, 10 months ago by Michael Achenbach

Modified:
6 years, 10 months ago

Reviewers:
ulan

CC:
v8-dev, Jakob Kummerow

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Refactor persisting state in push and merge scripts. - The backed state dict is now persisted and restored in the step template as a json file - All explicit persist/restore calls are removed - Added testing an unexpected script failure + restart with state recovery to the merge-to-branch test - This CL is not changing external behavior of the scripts BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19478

Patch Set 1 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+180 lines, -235 lines)			Patch
M	tools/push-to-trunk/auto_roll.py	View	5 chunks	+10 lines, -14 lines	0 comments	Download
M	tools/push-to-trunk/common_includes.py	View	9 chunks	+33 lines, -32 lines	0 comments	Download
M	tools/push-to-trunk/merge_to_branch.py	View	9 chunks	+46 lines, -77 lines	0 comments	Download
M	tools/push-to-trunk/push_to_trunk.py	View	16 chunks	+52 lines, -81 lines	0 comments	Download
M	tools/push-to-trunk/test_scripts.py	View	15 chunks	+39 lines, -31 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r19478.

Expand Messages | Collapse Messages