Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1705803002: Add `pkg/meta` (#25741). (Closed)

Created:
4 years, 10 months ago by pquitslund
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
A pkg/meta/lib/meta.dart View 1 chunk +23 lines, -0 lines 0 comments Download
A pkg/meta/pubspec.yaml View 1 chunk +10 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
https://codereview.chromium.org/1705803002/diff/1/pkg/meta/pubspec.yaml File pkg/meta/pubspec.yaml (right): https://codereview.chromium.org/1705803002/diff/1/pkg/meta/pubspec.yaml#newcode2 pkg/meta/pubspec.yaml:2: version: 0.9.0 Last published version was 0.8.8. FWIW I'm ...
4 years, 10 months ago (2016-02-17 17:15:08 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1705803002/diff/1/pkg/meta/pubspec.yaml File pkg/meta/pubspec.yaml (right): https://codereview.chromium.org/1705803002/diff/1/pkg/meta/pubspec.yaml#newcode2 pkg/meta/pubspec.yaml:2: version: 0.9.0 I think this is fine.
4 years, 10 months ago (2016-02-17 17:38:36 UTC) #3
pquitslund
4 years, 10 months ago (2016-02-17 17:44:34 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6a242d046aaaf73d41bf437ac20758da8bba2187 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698