Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 17058004: [sql] Static helper to delete database and all associated files. (Closed)

Created:
7 years, 6 months ago by Scott Hess - ex-Googler
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[sql] Static helper to delete database and all associated files. Not all of the ad-hoc file_util::Delete() cases handle -journal, and if -wal was added all of them need to be tracked down. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208140

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
M sql/connection.h View 1 chunk +12 lines, -0 lines 0 comments Download
M sql/connection.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M sql/connection_unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Scott Hess - ex-Googler
I hung it on sql::Connection because the path should correspond to that passed to Open(). ...
7 years, 6 months ago (2013-06-14 18:25:19 UTC) #1
rmcilroy
lgtm
7 years, 6 months ago (2013-06-17 09:44:40 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 6 months ago (2013-06-17 16:56:23 UTC) #3
Scott Hess - ex-Googler
On 2013/06/17 16:56:23, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
7 years, 6 months ago (2013-06-17 19:33:32 UTC) #4
Scott Hess - ex-Googler
On 2013/06/17 19:33:32, shess wrote: > On 2013/06/17 16:56:23, I haz the power (commit-bot) wrote: ...
7 years, 6 months ago (2013-06-18 22:16:43 UTC) #5
Scott Hess - ex-Googler
Greg, Brett is apparently AWOL. I've been abusing Erik for sql/ reviews on another front, ...
7 years, 6 months ago (2013-06-19 21:38:20 UTC) #6
brettw
lgtm
7 years, 6 months ago (2013-06-23 22:27:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/17058004/1
7 years, 6 months ago (2013-06-23 22:39:13 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-06-24 05:55:10 UTC) #9
Message was sent while issue was closed.
Change committed as 208140

Powered by Google App Engine
This is Rietveld 408576698