Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 1705773002: Discard function elements created while building elements in annotations (issue 25696) (Closed)

Created:
4 years, 10 months ago by Brian Wilkerson
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Discard function elements created while building elements in annotations (issue 25696) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/722623d2954a076d54ad9a2d88e2da756c823092

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -5 lines) Patch
M pkg/analyzer/lib/src/dart/element/builder.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 2 chunks +45 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 10 months ago (2016-02-17 16:19:13 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-17 16:21:47 UTC) #3
Brian Wilkerson
4 years, 10 months ago (2016-02-17 16:36:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
722623d2954a076d54ad9a2d88e2da756c823092 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698