Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 17057002: Remove bogus cast in LChunkBuilder::CreateEnvironment. (Closed)

Created:
7 years, 6 months ago by Michael Starzinger
Modified:
7 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Remove bogus cast in LChunkBuilder::CreateEnvironment. R=jkummerow@chromium.org TEST=chromium:content_browsertests Committed: http://code.google.com/p/v8/source/detail?r=15141

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
Of course arguments can also be Phi's. Please note that the removed assertion was initially ...
7 years, 6 months ago (2013-06-14 08:54:58 UTC) #1
Jakob Kummerow
lgtm
7 years, 6 months ago (2013-06-14 08:59:16 UTC) #2
Michael Starzinger
7 years, 6 months ago (2013-06-14 09:02:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15141 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698