Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1705673002: X87: [turbofan] Add an operator to access the parent frame pointer. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Add an operator to access the parent frame pointer. port fd8fd05cc5389a44a3d15ace0cf34b43369b758e (r34014) original commit message: This functionality is useful for stubs that need to walk the stack. The new machine operator, LoadParentFramePointer dosn't force the currently compiling method to have a frame in contrast to LoadFramePointer. Instead, it adapts accordingly when frame elision is possible, making efficient stack walks possible without incurring a performance penalty for small stubs that can benefit from frame elision. BUG= Committed: https://crrev.com/9727ab7e28400fcc9d40834f875d34cbd89ef026 Cr-Commit-Position: refs/heads/master@{#34064}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-17 07:31:06 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-17 09:11:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705673002/1
4 years, 10 months ago (2016-02-17 09:22:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 09:48:03 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 09:48:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9727ab7e28400fcc9d40834f875d34cbd89ef026
Cr-Commit-Position: refs/heads/master@{#34064}

Powered by Google App Engine
This is Rietveld 408576698