Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 170563002: Load target types and handlers before IC computation. (Closed)

Created:
6 years, 10 months ago by ulan
Modified:
6 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Load target types and handlers before IC computation. BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19455

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -56 lines) Patch
M src/ic.h View 3 chunks +17 lines, -1 line 0 comments Download
M src/ic.cc View 11 chunks +40 lines, -55 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
ulan
Toon, ptal, this is the refactoring we discussed that prepares IC to handle weak maps. ...
6 years, 10 months ago (2014-02-18 14:50:26 UTC) #1
Toon Verwaest
lgtm https://codereview.chromium.org/170563002/diff/1/src/ic.cc File src/ic.cc (right): https://codereview.chromium.org/170563002/diff/1/src/ic.cc#newcode635 src/ic.cc:635: handlers()->Set(handler_to_overwrite, code); This is done at the end ...
6 years, 10 months ago (2014-02-18 15:06:36 UTC) #2
ulan
6 years, 10 months ago (2014-02-18 15:13:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19455 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698