Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1705613002: Don't create DL shelf on CrOS when showing chrome://downloads (Closed)

Created:
4 years, 10 months ago by Evan Stade
Modified:
4 years, 10 months ago
Reviewers:
asanka, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't create DL shelf on CrOS when showing chrome://downloads BUG=582688 Committed: https://crrev.com/a2e16b35d80b44b41eabfa3327fede8f8042aa28 Cr-Commit-Position: refs/heads/master@{#376070}

Patch Set 1 #

Patch Set 2 : more narrow fix so tests don't break #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M chrome/browser/ui/chrome_pages.cc View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Evan Stade
4 years, 10 months ago (2016-02-17 01:45:15 UTC) #2
sky
LGTM
4 years, 10 months ago (2016-02-17 17:32:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705613002/1
4 years, 10 months ago (2016-02-17 22:46:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/126636)
4 years, 10 months ago (2016-02-17 23:21:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705613002/20001
4 years, 10 months ago (2016-02-18 01:44:56 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-18 02:29:34 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 02:31:04 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a2e16b35d80b44b41eabfa3327fede8f8042aa28
Cr-Commit-Position: refs/heads/master@{#376070}

Powered by Google App Engine
This is Rietveld 408576698