Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1705603002: MD Settings: Fixing positioning of reset profile dialog. (Closed)

Created:
4 years, 10 months ago by dpapad
Modified:
4 years, 10 months ago
Reviewers:
tommycli
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@manage_search_engines_strings
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fixing positioning of reset profile dialog. Removing extraneous call to center(), which after latest Polymer roll (rev 374191) started messing up the dialog position. BUG=586599 Committed: https://crrev.com/d6c915826b08b862faad42f3e5c8edd5651fe235 Cr-Commit-Position: refs/heads/master@{#376022}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M chrome/browser/resources/settings/reset_page/reset_profile_dialog.js View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dpapad
See attached bug for (complicated) explanation of what caused this bug.
4 years, 10 months ago (2016-02-17 20:29:41 UTC) #3
tommycli
lgtm
4 years, 10 months ago (2016-02-17 21:13:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705603002/20001
4 years, 10 months ago (2016-02-17 22:13:54 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 23:13:19 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 23:15:24 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d6c915826b08b862faad42f3e5c8edd5651fe235
Cr-Commit-Position: refs/heads/master@{#376022}

Powered by Google App Engine
This is Rietveld 408576698