Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 1705533003: Revert of DevTools: add input event instrumentation test (Closed)

Created:
4 years, 10 months ago by henrika (OOO until Aug 14)
Modified:
4 years, 10 months ago
Reviewers:
caseq, dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: add input event instrumentation test (patchset #2 id:40001 of https://codereview.chromium.org/1704723002/ ) Reason for revert: Seems to break DevToolsPixelOutputTests.TestLatencyInfoInstrumentation on Mac. See https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/12163 for details. Original issue's description: > DevTools: add input event instrumentation test > > BUG=554215 > > Committed: https://crrev.com/e99c42679051cd91ef92155bb7f190a9405acedc > Cr-Commit-Position: refs/heads/master@{#375802} TBR=dgozman@chromium.org,pfeldman@chromium.org,caseq@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=554215 Committed: https://crrev.com/f3eea78c715d6d2882dce9d731ee0aede2181046 Cr-Commit-Position: refs/heads/master@{#375847}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -263 lines) Patch
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 7 chunks +11 lines, -76 lines 0 comments Download
D chrome/test/data/devtools/latency_info.html View 1 chunk +0 lines, -103 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/TestBase.js View 3 chunks +1 line, -15 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Tests.js View 3 chunks +24 lines, -69 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
henrika (OOO until Aug 14)
Created Revert of DevTools: add input event instrumentation test
4 years, 10 months ago (2016-02-17 10:39:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705533003/1
4 years, 10 months ago (2016-02-17 10:40:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 10:41:36 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 10:42:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3eea78c715d6d2882dce9d731ee0aede2181046
Cr-Commit-Position: refs/heads/master@{#375847}

Powered by Google App Engine
This is Rietveld 408576698