Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3112)

Unified Diff: build/config/BUILD.gn

Issue 1705533002: Remove yasm (and DONT_EMBED_BUILD_METADATA). (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | third_party/yasm/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILD.gn
diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn
index 6e9336fa2b82b33ffea491cd403967b19ff13252..209118d2f64f5ddad3f1754d24a125a2dbfcda3a 100644
--- a/build/config/BUILD.gn
+++ b/build/config/BUILD.gn
@@ -15,17 +15,6 @@ declare_args() {
# catching bugs but in some cases may cause conflicts or excessive slowness.
disable_iterator_debugging = false
- # Set to true to not store any build metadata, e.g. ifdef out all __DATE__
- # and __TIME__. Set to 0 to reenable the use of these macros in the code
- # base. See http://crbug.com/314403.
- #
- # Continue to embed build meta data in Official builds, basically the
- # time it was built.
- # TODO(maruel): This decision should be revisited because having an
- # official deterministic build has high value too but MSVC toolset can't
- # generate anything deterministic with WPO enabled AFAIK.
- dont_embed_build_metadata = !is_official_build
-
# Set to true to enable dcheck in Release builds.
dcheck_always_on = false
@@ -47,9 +36,6 @@ config("feature_flags") {
if (cld_version > 0) {
defines += [ "CLD_VERSION=$cld_version" ]
}
- if (dont_embed_build_metadata) {
- defines += [ "DONT_EMBED_BUILD_METADATA" ]
- }
if (dcheck_always_on) {
defines += [ "DCHECK_ALWAYS_ON=1" ]
}
« no previous file with comments | « DEPS ('k') | third_party/yasm/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698