Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1705533002: Remove yasm (and DONT_EMBED_BUILD_METADATA). (Closed)

Created:
4 years, 10 months ago by viettrungluu
Modified:
4 years, 10 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24958 lines) Patch
M .gitignore View 1 chunk +0 lines, -2 lines 0 comments Download
M DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M build/config/BUILD.gn View 2 chunks +0 lines, -14 lines 0 comments Download
D third_party/yasm/BUILD.gn View 1 chunk +0 lines, -472 lines 0 comments Download
D third_party/yasm/CHROMIUM.diff View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/yasm/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/yasm/README.chromium View 1 chunk +0 lines, -142 lines 0 comments Download
D third_party/yasm/run_yasm.py View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/yasm/source/config/android/Makefile View 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/source/config/android/config.h View 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/yasm/source/config/android/libyasm-stdint.h View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/source/config/ios/Makefile View 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/source/config/ios/config.h View 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/yasm/source/config/ios/libyasm-stdint.h View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/source/config/linux/Makefile View 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/source/config/linux/config.h View 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/yasm/source/config/linux/libyasm-stdint.h View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/source/config/mac/Makefile View 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/source/config/mac/config.h View 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/yasm/source/config/mac/libyasm-stdint.h View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/source/config/openbsd/Makefile View 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/source/config/openbsd/config.h View 1 chunk +0 lines, -165 lines 0 comments Download
D third_party/yasm/source/config/openbsd/libyasm-stdint.h View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/source/config/win/Makefile View 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/source/config/win/config.h View 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/yasm/source/config/win/libyasm-stdint.h View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/source/config/win/stdint.h View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/yasm/yasm_assemble.gni View 1 chunk +0 lines, -203 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
viettrungluu
4 years, 10 months ago (2016-02-16 22:10:12 UTC) #1
viettrungluu
4 years, 10 months ago (2016-02-16 22:12:26 UTC) #5
jamesr
lgtm
4 years, 10 months ago (2016-02-16 22:13:46 UTC) #6
viettrungluu
4 years, 10 months ago (2016-02-16 22:19:56 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
49afea12c414df95e4a12974b443812293842cce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698