Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1705503002: Add SkCodec to the CMake build (Closed)

Created:
4 years, 10 months ago by msarett
Modified:
4 years, 10 months ago
Reviewers:
scroggo, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add SkCodec to the CMake build BUG=skia:4956 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1705503002 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/4691d99d7ede02c86c09312b0da56a4460f69940

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -9 lines) Patch
M cmake/CMakeLists.txt View 3 chunks +12 lines, -1 line 1 comment Download
M cmake/README.md View 1 chunk +0 lines, -4 lines 0 comments Download
M src/codec/SkGifCodec.cpp View 4 chunks +20 lines, -3 lines 0 comments Download
M src/codec/SkPngCodec.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
msarett
https://codereview.chromium.org/1705503002/diff/1/cmake/CMakeLists.txt File cmake/CMakeLists.txt (right): https://codereview.chromium.org/1705503002/diff/1/cmake/CMakeLists.txt#newcode151 cmake/CMakeLists.txt:151: if (NOT (GIF_FOUND AND JPEG_FOUND AND PNG_FOUND AND WEBP_INCLUDE_DIRS ...
4 years, 10 months ago (2016-02-16 19:47:12 UTC) #3
scroggo
lgtm
4 years, 10 months ago (2016-02-16 20:17:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705503002/1
4 years, 10 months ago (2016-02-16 20:20:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot on client.skia.compile (JOB_FAILED, no build URL)
4 years, 10 months ago (2016-02-16 20:20:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705503002/1
4 years, 10 months ago (2016-02-16 21:13:39 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot on client.skia.compile (JOB_FAILED, no build URL)
4 years, 10 months ago (2016-02-16 21:14:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705503002/1
4 years, 10 months ago (2016-02-16 21:15:45 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 21:16:42 UTC) #18
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4691d99d7ede02c86c09312b0da56a4460f69940

Powered by Google App Engine
This is Rietveld 408576698