Issue 170543002: Fix compile on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 170543002: Fix compile on Windows (Closed)

Created:
6 years, 10 months ago by alph

Modified:
6 years, 10 months ago

Reviewers:
Dmitry Lomov (no reviews), yurys

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix compile on Windows TBR=yurys@chromium.org,dslomov@chromium.org LOG=N Committed: https://code.google.com/p/v8/source/detail?r=19454

Patch Set 1 #

Total comments: 2

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/heap-snapshot-generator.cc	View		1 chunk	+2 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

alph

Committed patchset #1 manually as r19454 (tree was closed).

6 years, 10 months ago (2014-02-18 14:21:16 UTC) #1

Dmitry Lomov (no reviews)

https://codereview.chromium.org/170543002/diff/1/src/heap-snapshot-generator.cc File src/heap-snapshot-generator.cc (right): https://codereview.chromium.org/170543002/diff/1/src/heap-snapshot-generator.cc#newcode912 src/heap-snapshot-generator.cc:912: address, static_cast<unsigned int>(size)); Shouldn't this be size_t?

6 years, 10 months ago (2014-02-18 14:26:29 UTC) #2

alph

6 years, 10 months ago (2014-02-18 14:27:53 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/170543002/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):

https://codereview.chromium.org/170543002/diff/1/src/heap-snapshot-generator....
src/heap-snapshot-generator.cc:912: address, static_cast<unsigned int>(size));
On 2014/02/18 14:26:30, Dmitry Lomov (chromium) wrote:
> Shouldn't this be size_t?

Yes, it should. I just need a quick fix for now. Plan to update the
HeapObjectsMap to size_t in an upcoming patch.

Expand Messages | Collapse Messages