Source/core/dom/shadow/ShadowRoot.cpp - Issue 17054002: Element::recalcStyle() overly reattach()-es InsertionPoints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/shadow/ShadowRoot.cpp

Issue 17054002: Element::recalcStyle() overly reattach()-es InsertionPoints. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: For landing Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/shadow/ShadowRoot.cpp

diff --git a/Source/core/dom/shadow/ShadowRoot.cpp b/Source/core/dom/shadow/ShadowRoot.cpp

index fc40ea28119bf6fcbc608b8217aa42c25d944a7c..4780751a18aca586711f657738b4958305a7da38 100644

--- a/Source/core/dom/shadow/ShadowRoot.cpp

+++ b/Source/core/dom/shadow/ShadowRoot.cpp

@@ -145,6 +145,14 @@ void ShadowRoot::recalcStyle(StyleChange change)

if (styleChangeType() == FullStyleChange)

change = Force;

+ if (!attached()) {

+ attach();

+ // attach recalculates the style for all children. No need to do it twice.

+ clearNeedsStyleRecalc();

+ clearChildNeedsStyleRecalc();

+ return;

+ }

StyleResolver* styleResolver = document()->styleResolver();

styleResolver->pushParentShadowRoot(this);