Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1705373002: Whitelist Cast Extension to use WebView. (Closed)

Created:
4 years, 10 months ago by apacible
Modified:
4 years, 10 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Whitelist Cast Extension to use WebView. BUG=500075 Committed: https://crrev.com/394dc4560d60d96e3079dbb9a5fb2f151bbf7620 Cr-Commit-Position: refs/heads/master@{#376276}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M extensions/common/api/_permission_features.json View 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 11 (5 generated)
apacible
PTAL, thanks!
4 years, 10 months ago (2016-02-18 01:06:18 UTC) #3
Devlin
lgtm https://codereview.chromium.org/1705373002/diff/1/extensions/common/api/_permission_features.json File extensions/common/api/_permission_features.json (right): https://codereview.chromium.org/1705373002/diff/1/extensions/common/api/_permission_features.json#newcode480 extensions/common/api/_permission_features.json:480: "63ED55E43214C211F82122ED56407FF1A807F2A3", // http://crbug.com/500075 Wow. That's a bunch o' ...
4 years, 10 months ago (2016-02-18 20:10:56 UTC) #4
apacible
https://codereview.chromium.org/1705373002/diff/1/extensions/common/api/_permission_features.json File extensions/common/api/_permission_features.json (right): https://codereview.chromium.org/1705373002/diff/1/extensions/common/api/_permission_features.json#newcode480 extensions/common/api/_permission_features.json:480: "63ED55E43214C211F82122ED56407FF1A807F2A3", // http://crbug.com/500075 On 2016/02/18 20:10:56, Devlin wrote: > ...
4 years, 10 months ago (2016-02-18 21:01:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705373002/1
4 years, 10 months ago (2016-02-18 21:05:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 21:48:14 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 21:49:28 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/394dc4560d60d96e3079dbb9a5fb2f151bbf7620
Cr-Commit-Position: refs/heads/master@{#376276}

Powered by Google App Engine
This is Rietveld 408576698