Disable range requests if the origin ignores byte-range.

Disable range requests if the origin ignores byte-range.

Use the non-linearized PDF code path if the server doesn't respond to range
requests with a partial response. Previously, Chrome entered a request loop if
the PDF was linearized and the server advertized byte range support but
responded with a 200 code instead of 206.

BUG=587502
R=thestig@chromium.org
TEST=Load https://www.usenix.org/legacy/publications/library/proceedings/sec96/full_papers/goldberg/goldberg.pdf

Committed: https://crrev.com/d24b85fd27f774f8fcb68e112d6862d7afddcdd8
Cr-Commit-Position: refs/heads/master@{#376053}

[Lei Zhang, 2016-02-17 23:17:30]

LGTM, thanks for the quick fix.

For the future, do we want to write tests for cases like this? I'm not sure if
net/test/embedded_test_server/embedded_test_server.h can be customized to do
this.

[spelchat, 2016-02-17 23:23:34]

The CQ bit was checked by spelchat@chromium.org

[commit-bot: I haz the power, 2016-02-17 23:24:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1705353002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1705353002/1

[spelchat, 2016-02-17 23:30:30]

On 2016/02/17 23:17:30, Lei Zhang wrote:
> LGTM, thanks for the quick fix.
> 
> For the future, do we want to write tests for cases like this? I'm not sure if
> net/test/embedded_test_server/embedded_test_server.h can be customized to do
> this.

I'll look into adding a test. Looking at that class, I think it should be
possible, but I'm not familiar with it (or Chrome in general really). I'll try
to send a CL in the next few days.

[Lei Zhang, 2016-02-17 23:35:08]

On 2016/02/17 23:30:30, spelchat wrote:
> I'll look into adding a test. Looking at that class, I think it should be
> possible, but I'm not familiar with it (or Chrome in general really). I'll try
> to send a CL in the next few days.

No rush. Lots of opportunities to learn!

[commit-bot: I haz the power, 2016-02-18 00:31:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 00:31:06]

Exceeded global retry quota

[Lei Zhang, 2016-02-18 00:48:15]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-02-18 00:49:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1705353002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1705353002/1

[commit-bot: I haz the power, 2016-02-18 00:57:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-18 00:58:11]

Description was changed from

==========
Disable range requests if the origin ignores byte-range.

Use the non-linearized PDF code path if the server doesn't respond to range
requests with a partial response. Previously, Chrome entered a request loop if
the PDF was linearized and the server advertized byte range support but
responded with a 200 code instead of 206.

BUG=587502
R=thestig@chromium.org
TEST=Load
https://www.usenix.org/legacy/publications/library/proceedings/sec96/full_pap...
==========

to

==========
Disable range requests if the origin ignores byte-range.

Use the non-linearized PDF code path if the server doesn't respond to range
requests with a partial response. Previously, Chrome entered a request loop if
the PDF was linearized and the server advertized byte range support but
responded with a 200 code instead of 206.

BUG=587502
R=thestig@chromium.org
TEST=Load
https://www.usenix.org/legacy/publications/library/proceedings/sec96/full_pap...

Committed: https://crrev.com/d24b85fd27f774f8fcb68e112d6862d7afddcdd8
Cr-Commit-Position: refs/heads/master@{#376053}
==========

[commit-bot: I haz the power, 2016-02-18 00:58:12]

Patchset 1 (id:??) landed as
https://crrev.com/d24b85fd27f774f8fcb68e112d6862d7afddcdd8
Cr-Commit-Position: refs/heads/master@{#376053}

[spelchat, 2016-03-08 18:43:30]

On 2016/02/17 23:35:08, Lei Zhang (OOO) wrote:
> On 2016/02/17 23:30:30, spelchat wrote:
> > I'll look into adding a test. Looking at that class, I think it should be
> > possible, but I'm not familiar with it (or Chrome in general really). I'll
try
> > to send a CL in the next few days.
> 
> No rush. Lots of opportunities to learn!

Turns out this is only reproducible with the PDF from the bug. Unless it's OK to
add that PDF to the test data (I doubt it is), I think I'll have to punt on
adding a regression test for this issue.