Move VideoCapture* files from media/base/android/... to media/capture/video/android/java/...

Move VideoCapture* files from media/base/android/... to media/capture/video/android/java/...

** No code changes (except git cl format kicked by presbumit). **

This CL refactors the VideoCapture*java classes
from being under media/base/android/java/... into
media/capture/video/android/java/... with the idea
of bringing all such classes under a single roof
as a preparation for http://crbug.com/584797 (CL
http://crrev.com/1699553002) which creates an entity
(very similar to media/cast/ and media/midi/) with
its own .gn and .gyp.

BUG=587693, 584797
NOTRY=true

Committed: https://crrev.com/157c17e6d77e64efee6b82947506f544aac3b79f
Cr-Commit-Position: refs/heads/master@{#376409}

[mcasas, 2016-02-18 03:51:31]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-02-18 03:55:37]

Description was changed from

==========
Move VideoCapture* files from media/base/android/... to
media/capture/video/android/java/...

No code changes (except git cl format kicked by presbumit).

BUG=587693
==========

to

==========
Move VideoCapture* files from media/base/android/... to
media/capture/video/android/java/...

** No code changes (except git cl format kicked by presbumit). **

This CL refactors the VideoCapture*java classes 
from being under media/base/android/java/... into
media/capture/video/android/java/... with the idea
of bringing all such classes under a single roof 
as a preparation for http://crbug.com/584797 (CL
http://crrev.com/1699553002) which creates an entity
(very similar to media/cast/ and media/midi/) with
its own .gn and .gyp.


BUG=587693
==========

[mcasas, 2016-02-18 04:27:37]

Patchset #1 (id:20001) has been deleted

[mcasas, 2016-02-18 04:34:01]

Patchset #1 (id:40001) has been deleted

[mcasas, 2016-02-18 04:51:16]

mcasas@chromium.org changed reviewers:
+ qinmin@chromium.org

[mcasas, 2016-02-18 04:51:16]

qinmin@ PTAL (no new code)

[qinmin, 2016-02-18 17:55:52]

lgtm

[mcasas, 2016-02-18 18:02:37]

mcasas@chromium.org changed reviewers:
+ avi@chromium.org, dalecurtis@chromium.org

[mcasas, 2016-02-18 18:02:37]

dalecurtis@ media/ Owners RS 
avi@ content/ Owners RS

--> mecahnical conversions in gyps and gns

[Avi (use Gerrit), 2016-02-18 18:41:46]

lgtm

content stampity stamp

[DaleCurtis, 2016-02-18 18:57:41]

lgtm

[mcasas, 2016-02-18 19:00:30]

mcasas@chromium.org changed reviewers:
+ dtrainor@chromium.org

[mcasas, 2016-02-18 19:00:30]

dtrainor@ chrome/android/BUILD.gn
(automatic conversion of dep)

[David Trainor- moved to gerrit, 2016-02-18 19:13:30]

chrome/android/BUILD.gn lgtm

[mcasas, 2016-02-18 20:15:35]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-02-18 20:15:35]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
qinmin@chromium.org
Link to the patchset: https://codereview.chromium.org/1705333003/#ps70001
(title: "reuploaded w --similarity=75")

[mcasas, 2016-02-18 20:16:40]

Description was changed from

==========
Move VideoCapture* files from media/base/android/... to
media/capture/video/android/java/...

** No code changes (except git cl format kicked by presbumit). **

This CL refactors the VideoCapture*java classes 
from being under media/base/android/java/... into
media/capture/video/android/java/... with the idea
of bringing all such classes under a single roof 
as a preparation for http://crbug.com/584797 (CL
http://crrev.com/1699553002) which creates an entity
(very similar to media/cast/ and media/midi/) with
its own .gn and .gyp.


BUG=587693
==========

to

==========
Move VideoCapture* files from media/base/android/... to
media/capture/video/android/java/...

** No code changes (except git cl format kicked by presbumit). **

This CL refactors the VideoCapture*java classes 
from being under media/base/android/java/... into
media/capture/video/android/java/... with the idea
of bringing all such classes under a single roof 
as a preparation for http://crbug.com/584797 (CL
http://crrev.com/1699553002) which creates an entity
(very similar to media/cast/ and media/midi/) with
its own .gn and .gyp.


BUG=587693, 584797
==========

[commit-bot: I haz the power, 2016-02-18 20:20:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1705333003/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1705333003/70001

[mcasas, 2016-02-18 22:24:28]

The CQ bit was unchecked by mcasas@chromium.org

[mcasas, 2016-02-18 22:24:37]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-02-18 22:28:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1705333003/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1705333003/70001

[mcasas, 2016-02-18 22:32:47]

The CQ bit was unchecked by mcasas@chromium.org

[mcasas, 2016-02-18 22:55:41]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-02-18 22:56:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1705333003/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1705333003/70001

[commit-bot: I haz the power, 2016-02-19 02:44:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 02:44:20]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mcasas, 2016-02-19 03:02:45]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-02-19 03:10:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1705333003/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1705333003/70001

[mcasas, 2016-02-19 06:38:33]

Description was changed from

==========
Move VideoCapture* files from media/base/android/... to
media/capture/video/android/java/...

** No code changes (except git cl format kicked by presbumit). **

This CL refactors the VideoCapture*java classes 
from being under media/base/android/java/... into
media/capture/video/android/java/... with the idea
of bringing all such classes under a single roof 
as a preparation for http://crbug.com/584797 (CL
http://crrev.com/1699553002) which creates an entity
(very similar to media/cast/ and media/midi/) with
its own .gn and .gyp.


BUG=587693, 584797
==========

to

==========
Move VideoCapture* files from media/base/android/... to
media/capture/video/android/java/...

** No code changes (except git cl format kicked by presbumit). **

This CL refactors the VideoCapture*java classes 
from being under media/base/android/java/... into
media/capture/video/android/java/... with the idea
of bringing all such classes under a single roof 
as a preparation for http://crbug.com/584797 (CL
http://crrev.com/1699553002) which creates an entity
(very similar to media/cast/ and media/midi/) with
its own .gn and .gyp.


BUG=587693, 584797
NOTRY=true
==========

[mcasas, 2016-02-19 06:38:42]

The CQ bit was unchecked by mcasas@chromium.org

[mcasas, 2016-02-19 06:39:41]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-02-19 06:40:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1705333003/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1705333003/70001

[commit-bot: I haz the power, 2016-02-19 06:50:47]

Description was changed from

==========
Move VideoCapture* files from media/base/android/... to
media/capture/video/android/java/...

** No code changes (except git cl format kicked by presbumit). **

This CL refactors the VideoCapture*java classes 
from being under media/base/android/java/... into
media/capture/video/android/java/... with the idea
of bringing all such classes under a single roof 
as a preparation for http://crbug.com/584797 (CL
http://crrev.com/1699553002) which creates an entity
(very similar to media/cast/ and media/midi/) with
its own .gn and .gyp.


BUG=587693, 584797
NOTRY=true
==========

to

==========
Move VideoCapture* files from media/base/android/... to
media/capture/video/android/java/...

** No code changes (except git cl format kicked by presbumit). **

This CL refactors the VideoCapture*java classes 
from being under media/base/android/java/... into
media/capture/video/android/java/... with the idea
of bringing all such classes under a single roof 
as a preparation for http://crbug.com/584797 (CL
http://crrev.com/1699553002) which creates an entity
(very similar to media/cast/ and media/midi/) with
its own .gn and .gyp.


BUG=587693, 584797
NOTRY=true
==========

[commit-bot: I haz the power, 2016-02-19 06:50:49]

Committed patchset #2 (id:70001)

[commit-bot: I haz the power, 2016-02-19 06:51:36]

Description was changed from

==========
Move VideoCapture* files from media/base/android/... to
media/capture/video/android/java/...

** No code changes (except git cl format kicked by presbumit). **

This CL refactors the VideoCapture*java classes 
from being under media/base/android/java/... into
media/capture/video/android/java/... with the idea
of bringing all such classes under a single roof 
as a preparation for http://crbug.com/584797 (CL
http://crrev.com/1699553002) which creates an entity
(very similar to media/cast/ and media/midi/) with
its own .gn and .gyp.


BUG=587693, 584797
NOTRY=true
==========

to

==========
Move VideoCapture* files from media/base/android/... to
media/capture/video/android/java/...

** No code changes (except git cl format kicked by presbumit). **

This CL refactors the VideoCapture*java classes
from being under media/base/android/java/... into
media/capture/video/android/java/... with the idea
of bringing all such classes under a single roof
as a preparation for http://crbug.com/584797 (CL
http://crrev.com/1699553002) which creates an entity
(very similar to media/cast/ and media/midi/) with
its own .gn and .gyp.

BUG=587693, 584797
NOTRY=true

Committed: https://crrev.com/157c17e6d77e64efee6b82947506f544aac3b79f
Cr-Commit-Position: refs/heads/master@{#376409}
==========

[commit-bot: I haz the power, 2016-02-19 06:51:38]

Patchset 2 (id:??) landed as
https://crrev.com/157c17e6d77e64efee6b82947506f544aac3b79f
Cr-Commit-Position: refs/heads/master@{#376409}

[clamy, 2016-02-19 14:37:50]

A revert of this CL (patchset #2 id:70001) has been created in
https://codereview.chromium.org/1710373002/ by clamy@chromium.org.

The reason for reverting is: Android WebView tests started failing after 4 CLs
landed including this one, and it seems like the most likely culprit. See
https://build.chromium.org/p/chromium.android/builders/Android%20Webview%20L%...
and
https://build.chromium.org/p/chromium.android/builders/Android%20Webview%20M%....

[clamy, 2016-02-19 15:41:15]

On 2016/02/19 14:37:50, clamy wrote:
> A revert of this CL (patchset #2 id:70001) has been created in
> https://codereview.chromium.org/1710373002/ by mailto:clamy@chromium.org.
> 
> The reason for reverting is: Android WebView tests started failing after 4 CLs
> landed including this one, and it seems like the most likely culprit. See
>
https://build.chromium.org/p/chromium.android/builders/Android%20Webview%20L%...
> and
>
https://build.chromium.org/p/chromium.android/builders/Android%20Webview%20M%....

The revert fixed the breakages on Android WebView. I suspect this CL is linked
to other test issues on Android (hence why the android bot turned purple on the
CQ try). I will update once the revert has rolled in, to see if it fixes the
issues seen on the other bots.

[jabdelmalek, 2016-02-19 15:51:42]

Please don't use NOTRY=true per
https://www.chromium.org/developers/testing/commit-queue#TOC-Options

[clamy, 2016-02-19 16:06:23]

clamy@chromium.org changed reviewers:
+ clamy@chromium.org

[clamy, 2016-02-19 16:06:24]

Now confirmed. The CL caused an error on Chrome at startup time, preventing
anything to be run.

[mcasas, 2016-02-19 16:56:59]

On 2016/02/19 16:06:24, clamy wrote:
> Now confirmed. The CL caused an error on Chrome at startup time, preventing
> anything to be run.

Apologies and thanks!