Issue 170533003: GN: Work on Linux build defines

Issue 170533003: GN: Work on Linux build defines (Closed)

Created:
6 years, 10 months ago by brettw

Modified:
6 years, 10 months ago

Reviewers:
scottmg

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

GN: Work on Linux build defines This makes the -D defines for the default desktop Linux build of re2 in GN match that of GYP. This moves the SSL configuration stuff into the root build directory. It's better to match the GYP build exactly for ease of landing even though this is a stupid dependency. Fixes the help text that still references the implicit "gen" command (I removed this). R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252981

Patch Set 1 #

Patch Set 2 : revert deps #

Patch Set 3 : Move printing out #

Total comments: 1

Patch Set 4 : Fix #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -26 lines)			Patch
M	build/config/BUILD.gn	View		2 chunks	+51 lines, -3 lines	0 comments	Download
A +	build/config/crypto.gni	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	build/config/features.gni	View	1 2 3	1 chunk	+49 lines, -0 lines	0 comments	Download
M	build/config/ui.gni	View		3 chunks	+23 lines, -0 lines	0 comments	Download
M	build/gyp_chromium	View	1 2	2 chunks	+6 lines, -0 lines	0 comments	Download
M	tools/gn/command_help.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/gn/secondary/chrome/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gn/secondary/crypto/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gn/secondary/crypto/ssl/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
D	tools/gn/secondary/crypto/ssl/flags.gni	View		1 chunk	+0 lines, -17 lines	0 comments	Download
M	tools/gn/secondary/net/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scottmg

https://codereview.chromium.org/170533003/diff/340001/build/config/features.gni File build/config/features.gni (right): https://codereview.chromium.org/170533003/diff/340001/build/config/features.gni#newcode42 build/config/features.gni:42: # Enable printing support and UI. This variable is ...

6 years, 10 months ago (2014-02-20 23:06:23 UTC) #2

brettw

6 years, 10 months ago (2014-02-24 21:29:54 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r252981 (presubmit successful).

Expand Messages | Collapse Messages