Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1705323004:
Support blacklisting domains for Reader Mode (Closed)
|
Created:
4 years, 10 months ago by wychen Modified:
4 years, 10 months ago Reviewers:
mdjones CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSupport blacklisting domains for Reader Mode
The contents on some domains are mostly certainly not suitable for DOM
distiller to extract, and the triggering logic sometimes has false
positives.
BUG=587974
Committed: https://crrev.com/e8ef9f9ef375bd1a0cbe43ee0327a20c122ca781
Cr-Commit-Position: refs/heads/master@{#376281}
Patch Set 1 #
Total comments: 1
Patch Set 2 : move constant #
Dependent Patchsets: Messages
Total messages: 18 (10 generated)
wychen@chromium.org changed reviewers: + mdjones@chromium.org
PTAL
The CQ bit was checked by wychen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705323004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705323004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/1705323004/diff/1/components/dom_distiller/co... File components/dom_distiller/content/renderer/distillability_agent.cc (right): https://codereview.chromium.org/1705323004/diff/1/components/dom_distiller/co... components/dom_distiller/content/renderer/distillability_agent.cc:53: const char* const kBlacklist[] = { Being a constant, this could probably be at the top of the file/namespace. I don't feel too strongly about this though.
The CQ bit was checked by wychen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mdjones@chromium.org Link to the patchset: https://codereview.chromium.org/1705323004/#ps20001 (title: "move constant")
The CQ bit was unchecked by wychen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705323004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705323004/20001
Description was changed from ========== Support blacklisting domains for Reader Mode The contents on some domains are mostly certainly not suitable for DOM distiller to extract, and the triggering logic sometimes has false positives. BUG= ========== to ========== Support blacklisting domains for Reader Mode The contents on some domains are mostly certainly not suitable for DOM distiller to extract, and the triggering logic sometimes has false positives. BUG=587974 ==========
The CQ bit was checked by wychen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705323004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705323004/20001
Message was sent while issue was closed.
Description was changed from ========== Support blacklisting domains for Reader Mode The contents on some domains are mostly certainly not suitable for DOM distiller to extract, and the triggering logic sometimes has false positives. BUG=587974 ========== to ========== Support blacklisting domains for Reader Mode The contents on some domains are mostly certainly not suitable for DOM distiller to extract, and the triggering logic sometimes has false positives. BUG=587974 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Support blacklisting domains for Reader Mode The contents on some domains are mostly certainly not suitable for DOM distiller to extract, and the triggering logic sometimes has false positives. BUG=587974 ========== to ========== Support blacklisting domains for Reader Mode The contents on some domains are mostly certainly not suitable for DOM distiller to extract, and the triggering logic sometimes has false positives. BUG=587974 Committed: https://crrev.com/e8ef9f9ef375bd1a0cbe43ee0327a20c122ca781 Cr-Commit-Position: refs/heads/master@{#376281} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e8ef9f9ef375bd1a0cbe43ee0327a20c122ca781 Cr-Commit-Position: refs/heads/master@{#376281} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
