Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 1705313002: Revert of GN: Normalize the build directory path (Closed)

Created:
4 years, 10 months ago by brettw
Modified:
4 years, 10 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of GN: Normalize the build directory path (patchset #1 id:1 of https://codereview.chromium.org/1708513002/ ) Reason for revert: Doesn't work on bots (link in previous comment). Original issue's description: > GN: Normalize the build directory path > > BUG=586906 > TEST=ln -s /tmp out_tmp && out/gn/gn gen out_tmp/Release > > Committed: https://crrev.com/89d33db3bfd53fbb3d85bb218ad4db8489a4dc34 > Cr-Commit-Position: refs/heads/master@{#375970} TBR=hashimoto@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=586906 Committed: https://crrev.com/9a3e795d6956aca4656c3c0d7d42541051b0c7c2 Cr-Commit-Position: refs/heads/master@{#376004}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M tools/gn/setup.cc View 1 chunk +1 line, -14 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
brettw
Created Revert of GN: Normalize the build directory path
4 years, 10 months ago (2016-02-17 22:22:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705313002/1
4 years, 10 months ago (2016-02-17 22:26:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 22:29:55 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 22:31:46 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a3e795d6956aca4656c3c0d7d42541051b0c7c2
Cr-Commit-Position: refs/heads/master@{#376004}

Powered by Google App Engine
This is Rietveld 408576698