TaskScheduler [3/9] Task and Sequence

base/task_scheduler/task_traits.h

Index: base/task_scheduler/task_traits.h
diff --git a/base/task_scheduler/task_traits.h b/base/task_scheduler/task_traits.h
index 156624120bc0bb50678e2a476d3c1fe439a3ba9d..b6fcb33b238158b7bcfecef8a6299393bb3d7429 100644
--- a/base/task_scheduler/task_traits.h
+++ b/base/task_scheduler/task_traits.h
@@ -5,37 +5,38 @@
 #ifndef BASE_TASK_SCHEDULER_TASK_TRAITS_H_
 #define BASE_TASK_SCHEDULER_TASK_TRAITS_H_
 
+#include <stdint.h>
+
+#include <iosfwd>
+
 #include "base/base_export.h"
 #include "build/build_config.h"
 
 namespace base {
 
-using TaskPriorityUnderlyingType = char;
-
-// Valid priorities supported by the task scheduler.
-// A higher value means a higher priority in the scheduler.
-enum class TaskPriority : TaskPriorityUnderlyingType {
-  // This task affects UI immediately after a user interaction.
-  // Example: Generating data shown in the UI immediately after a click.
-  USER_BLOCKING = 2,
+// Valid priorities supported by the task scheduler. Note: internal algorithms
+// depend on priorities being expressed as a continuous zero-based list from
+// lowest to highest priority. Users of this API shouldn't otherwise care about
+// nor use the underlying values.
+enum class TaskPriority {
+  // This will always be equal to the lowest priority available.
+  LOWEST = 0,
+  // User won't notice if this task takes an arbitrarily long time to complete.
+  BACKGROUND = LOWEST,
   // This task affects UI or responsiveness of future user interactions. It is
   // not an immediate response to a user interaction.
   // Examples:
   // - Updating the UI to reflect progress on a long task.
   // - Loading data that might be shown in the UI after a future user
   //   interaction.
-  USER_VISIBLE = 1,
-  // Everything else (user won't notice if this takes an arbitrarily long time
-  // to complete).
-  BACKGROUND = 0,
+  USER_VISIBLE,
+  // This task affects UI immediately after a user interaction.
+  // Example: Generating data shown in the UI immediately after a click.
+  USER_BLOCKING,
+  // This will always be equal to the highest priority available.
+  HIGHEST = USER_BLOCKING,
 };
 
-static_assert(TaskPriority::BACKGROUND < TaskPriority::USER_VISIBLE &&
-                  TaskPriority::USER_VISIBLE < TaskPriority::USER_BLOCKING,
-              "Higher priorities must correspond to higher underlying values.");
-
-const TaskPriorityUnderlyingType kNumTaskPriorities = 3;
-
 // Valid shutdown behaviors supported by the task scheduler.
 enum class TaskShutdownBehavior {
   // Tasks posted with this mode which have not started executing before
@@ -76,6 +77,7 @@ enum class TaskShutdownBehavior {
 
 // Describes metadata for a single task or a group of tasks.
 class BASE_EXPORT TaskTraits {

[gab, 2016/03/16 22:18:50]

Since classes should typically have DISALLOW_COPY_AND_ASSIGN and this one is
intentionally copyable I think it makes sense to highlight that this was an
intentional decision by declaring the use of the default copy constructor below.

TaskTraits(const TaskTraits& other) = default;

And also declare:

TaskTraits& operator=(const TaskTraits& other) = default;

per the style rule that if one is defined the other one also should be:

"If you define a copy or move constructor, define the corresponding assignment
operator, and vice-versa. If your type is copyable"
@
https://google.github.io/styleguide/cppguide.html#Copyable_Movable_Types

[fdoray, 2016/03/17 00:42:33]

Done.

+ public:
   // Constructs a default TaskTraits for tasks with
   //     (1) no I/O,
   //     (2) low priority, and
@@ -122,6 +124,9 @@ enum class ExecutionMode {
   SINGLE_THREADED,
 };
 
+// Pretty Printer for Google Test.
+void BASE_EXPORT PrintTo(const TaskPriority& task_priority, std::ostream* os);
+
 }  // namespace base
 
 #endif  // BASE_TASK_SCHEDULER_TASK_TRAITS_H_