TaskScheduler [3/9] Task and Sequence

base/task_scheduler/task.h

Index: base/task_scheduler/task.h
diff --git a/base/task_scheduler/task.h b/base/task_scheduler/task.h
new file mode 100644
index 0000000000000000000000000000000000000000..1290d20aa6cc266d4f6d0f026691b485955f797e
--- /dev/null
+++ b/base/task_scheduler/task.h
@@ -0,0 +1,39 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BASE_TASK_SCHEDULER_TASK_H_
+#define BASE_TASK_SCHEDULER_TASK_H_
+
+#include "base/base_export.h"
+#include "base/callback_forward.h"
+#include "base/location.h"
+#include "base/pending_task.h"
+#include "base/task_scheduler/task_traits.h"
+#include "base/time/time.h"
+
+namespace base {
+namespace internal {
+
+// A task is a unit of work inside the task scheduler. Support for tracing and
+// profiling inherited from PendingTask.
+struct BASE_EXPORT Task : public PendingTask {
+  Task(const tracked_objects::Location& posted_from,
+       const Closure& task,
+       const TaskTraits& traits,
+       const TimeTicks& sequenced_time);
+  ~Task();
+
+  // The TaskTraits of this task.
+  TaskTraits traits;
+
+  // The time at which the task was inserted in its sequence. For an undelayed
+  // task, this happens at post time. For a delayed task, this happens some
+  // time after the task's delay has expired.
+  TimeTicks sequenced_time;

[robliao, 2016/02/19 02:33:43]

This should probably be const. I suspect that impacts STL container usage, so
you can turn this into a class and make these private and add getters.

[fdoray, 2016/02/19 14:12:15]

It can't be const because for a delayed task, it isn't set when the task is
constructed.

This is currently set by TaskRunners/DelayedTaskManager before pushing the task
in a sequence, but it should probably be set by Sequence::PushTask instead.
WDYT?

[robliao, 2016/02/22 21:34:12]

sgtm.

+};
+
+}  // namespace internal
+}  // namespace base
+
+#endif  // BASE_TASK_SCHEDULER_TASK_H_