Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: base/task_scheduler/sequence_unittest.cc

Issue 1705253002: TaskScheduler [3/9] Task and Sequence (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@s_1_scheduler_lock
Patch Set: CR from Dana and Gab #40-41 Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/task_scheduler/sequence_sort_key_unittest.cc ('k') | base/task_scheduler/task.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/task_scheduler/sequence.h"
6
7 #include "base/macros.h"
8 #include "base/time/time.h"
9 #include "testing/gtest/include/gtest/gtest.h"
10
11 namespace base {
12 namespace internal {
13
14 namespace {
15
16 class TaskSchedulerSequenceTest : public testing::Test {
17 public:
18 TaskSchedulerSequenceTest()
19 : task_a_owned_(
20 new Task(FROM_HERE,
21 Closure(),
22 TaskTraits().WithPriority(TaskPriority::BACKGROUND))),
23 task_b_owned_(
24 new Task(FROM_HERE,
25 Closure(),
26 TaskTraits().WithPriority(TaskPriority::USER_VISIBLE))),
27 task_c_owned_(
28 new Task(FROM_HERE,
29 Closure(),
30 TaskTraits().WithPriority(TaskPriority::USER_BLOCKING))),
31 task_d_owned_(
32 new Task(FROM_HERE,
33 Closure(),
34 TaskTraits().WithPriority(TaskPriority::USER_BLOCKING))),
35 task_e_owned_(
36 new Task(FROM_HERE,
37 Closure(),
38 TaskTraits().WithPriority(TaskPriority::BACKGROUND))),
39 task_a_(task_a_owned_.get()),
40 task_b_(task_b_owned_.get()),
41 task_c_(task_c_owned_.get()),
42 task_d_(task_d_owned_.get()),
43 task_e_(task_e_owned_.get()) {}
44
45 protected:
46 // Tasks to be handed off to a Sequence for testing.
47 scoped_ptr<Task> task_a_owned_;
48 scoped_ptr<Task> task_b_owned_;
49 scoped_ptr<Task> task_c_owned_;
50 scoped_ptr<Task> task_d_owned_;
51 scoped_ptr<Task> task_e_owned_;
52
53 // Raw pointers to those same tasks for verification. This is needed because
54 // the scoped_ptrs above no longer point to the tasks once they have been
55 // moved into a Sequence.
56 const Task* task_a_;
57 const Task* task_b_;
58 const Task* task_c_;
59 const Task* task_d_;
60 const Task* task_e_;
61
62 private:
63 DISALLOW_COPY_AND_ASSIGN(TaskSchedulerSequenceTest);
64 };
65
66 void ExpectSortKey(TaskPriority expected_priority,
67 TimeTicks expected_sequenced_time,
68 const SequenceSortKey& actual_sort_key) {
69 EXPECT_EQ(expected_priority, actual_sort_key.priority);
70 EXPECT_EQ(expected_sequenced_time, actual_sort_key.next_task_sequenced_time);
71 }
72
73 } // namespace
74
75 TEST_F(TaskSchedulerSequenceTest, PushPopPeek) {
76 scoped_refptr<Sequence> sequence(new Sequence);
77
78 // Push task A in the sequence. Its sequenced time should be updated and it
79 // should be in front of the sequence.
80 EXPECT_TRUE(sequence->PushTask(std::move(task_a_owned_)));
81 EXPECT_FALSE(task_a_->sequenced_time.is_null());
82 EXPECT_EQ(task_a_, sequence->PeekTask());
83
84 // Push task B, C and D in the sequence. Their sequenced time should be
85 // updated and task A should always remain in front of the sequence.
86 EXPECT_FALSE(sequence->PushTask(std::move(task_b_owned_)));
87 EXPECT_FALSE(task_b_->sequenced_time.is_null());
88 EXPECT_EQ(task_a_, sequence->PeekTask());
89
90 EXPECT_FALSE(sequence->PushTask(std::move(task_c_owned_)));
91 EXPECT_FALSE(task_c_->sequenced_time.is_null());
92 EXPECT_EQ(task_a_, sequence->PeekTask());
93
94 EXPECT_FALSE(sequence->PushTask(std::move(task_d_owned_)));
95 EXPECT_FALSE(task_d_->sequenced_time.is_null());
96 EXPECT_EQ(task_a_, sequence->PeekTask());
97
98 // Pop task A. Task B should now be in front.
99 EXPECT_FALSE(sequence->PopTask());
100 EXPECT_EQ(task_b_, sequence->PeekTask());
101
102 // Pop task B. Task C should now be in front.
103 EXPECT_FALSE(sequence->PopTask());
104 EXPECT_EQ(task_c_, sequence->PeekTask());
105
106 // Pop task C. Task D should now be in front.
107 EXPECT_FALSE(sequence->PopTask());
108 EXPECT_EQ(task_d_, sequence->PeekTask());
109
110 // Push task E in the sequence. Its sequenced time should be updated and
111 // task D should remain in front.
112 EXPECT_FALSE(sequence->PushTask(std::move(task_e_owned_)));
113 EXPECT_FALSE(task_e_->sequenced_time.is_null());
114 EXPECT_EQ(task_d_, sequence->PeekTask());
115
116 // Pop task D. Task E should now be in front.
117 EXPECT_FALSE(sequence->PopTask());
118 EXPECT_EQ(task_e_, sequence->PeekTask());
119
120 // Pop task E. The sequence should now be empty.
121 EXPECT_TRUE(sequence->PopTask());
122 EXPECT_EQ(nullptr, sequence->PeekTask());
123 }
124
125 TEST_F(TaskSchedulerSequenceTest, GetSortKey) {
126 scoped_refptr<Sequence> sequence(new Sequence);
127
128 // Push task A in the sequence. The highest priority is from task A
129 // (BACKGROUND). Task A is in front of the sequence.
130 sequence->PushTask(std::move(task_a_owned_));
131 ExpectSortKey(TaskPriority::BACKGROUND, task_a_->sequenced_time,
132 sequence->GetSortKey());
133
134 // Push task B in the sequence. The highest priority is from task B
135 // (USER_VISIBLE). Task A is still in front of the sequence.
136 sequence->PushTask(std::move(task_b_owned_));
137 ExpectSortKey(TaskPriority::USER_VISIBLE, task_a_->sequenced_time,
138 sequence->GetSortKey());
139
140 // Push task C in the sequence. The highest priority is from task C
141 // (USER_BLOCKING). Task A is still in front of the sequence.
142 sequence->PushTask(std::move(task_c_owned_));
143 ExpectSortKey(TaskPriority::USER_BLOCKING, task_a_->sequenced_time,
144 sequence->GetSortKey());
145
146 // Push task D in the sequence. The highest priority is from tasks C/D
147 // (USER_BLOCKING). Task A is still in front of the sequence.
148 sequence->PushTask(std::move(task_d_owned_));
149 ExpectSortKey(TaskPriority::USER_BLOCKING, task_a_->sequenced_time,
150 sequence->GetSortKey());
151
152 // Pop task A. The highest priority is still USER_BLOCKING. The task in front
153 // of the sequence is now task B.
154 sequence->PopTask();
155 ExpectSortKey(TaskPriority::USER_BLOCKING, task_b_->sequenced_time,
156 sequence->GetSortKey());
157
158 // Pop task B. The highest priority is still USER_BLOCKING. The task in front
159 // of the sequence is now task C.
160 sequence->PopTask();
161 ExpectSortKey(TaskPriority::USER_BLOCKING, task_c_->sequenced_time,
162 sequence->GetSortKey());
163
164 // Pop task C. The highest priority is still USER_BLOCKING. The task in front
165 // of the sequence is now task D.
166 sequence->PopTask();
167 ExpectSortKey(TaskPriority::USER_BLOCKING, task_d_->sequenced_time,
168 sequence->GetSortKey());
169
170 // Push task E in the sequence. The highest priority is still USER_BLOCKING.
171 // The task in front of the sequence is still task D.
172 sequence->PushTask(std::move(task_e_owned_));
173 ExpectSortKey(TaskPriority::USER_BLOCKING, task_d_->sequenced_time,
174 sequence->GetSortKey());
175
176 // Pop task D. The highest priority is now from task E (BACKGROUND). The
177 // task in front of the sequence is now task E.
178 sequence->PopTask();
179 ExpectSortKey(TaskPriority::BACKGROUND, task_e_->sequenced_time,
180 sequence->GetSortKey());
181 }
182
183 } // namespace internal
184 } // namespace base
OLDNEW
« no previous file with comments | « base/task_scheduler/sequence_sort_key_unittest.cc ('k') | base/task_scheduler/task.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698