Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: base/task_scheduler/sequence_unittest.cc

Issue 1705253002: TaskScheduler [3/9] Task and Sequence (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@s_1_scheduler_lock
Patch Set: remove scheduler lock from diff Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/task_scheduler/sequence_sort_key_unittest.cc ('k') | base/task_scheduler/task.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/task_scheduler/sequence.h"
6
7 #include "base/macros.h"
8 #include "base/time/time.h"
9 #include "testing/gtest/include/gtest/gtest.h"
10
11 namespace base {
12 namespace internal {
13
14 namespace {
15
16 class TaskSchedulerSequenceTest : public testing::Test {
17 public:
18 TaskSchedulerSequenceTest()
19 : task_a_(new Task(FROM_HERE,
20 Closure(),
21 TaskTraits().WithPriority(TaskPriority::BACKGROUND))),
22 task_b_(
23 new Task(FROM_HERE,
24 Closure(),
25 TaskTraits().WithPriority(TaskPriority::USER_VISIBLE))),
26 task_c_(
27 new Task(FROM_HERE,
28 Closure(),
29 TaskTraits().WithPriority(TaskPriority::USER_BLOCKING))),
30 task_d_(
31 new Task(FROM_HERE,
32 Closure(),
33 TaskTraits().WithPriority(TaskPriority::USER_BLOCKING))),
34 task_e_(new Task(FROM_HERE,
35 Closure(),
36 TaskTraits().WithPriority(TaskPriority::BACKGROUND))),
37 task_a_raw_(task_a_.get()),
38 task_b_raw_(task_b_.get()),
39 task_c_raw_(task_c_.get()),
40 task_d_raw_(task_d_.get()),
41 task_e_raw_(task_e_.get()) {}
42
43 protected:
44 scoped_ptr<Task> task_a_;
gab 2016/02/22 17:12:21 // Tasks to handed off to a Sequence for testing.
fdoray 2016/02/22 18:07:54 Done.
45 scoped_ptr<Task> task_b_;
46 scoped_ptr<Task> task_c_;
47 scoped_ptr<Task> task_d_;
48 scoped_ptr<Task> task_e_;
49
50 const Task* task_a_raw_;
gab 2016/02/22 17:12:21 // Raw pointers to those same tasks for verificati
fdoray 2016/02/22 18:07:54 Done.
51 const Task* task_b_raw_;
52 const Task* task_c_raw_;
53 const Task* task_d_raw_;
54 const Task* task_e_raw_;
gab 2016/02/22 17:12:21 Why not just inline .get()? ".get()" almost the sa
fdoray 2016/02/22 18:07:55 Once |task_x_| has been moved in a sequence, task_
gab 2016/02/22 20:00:20 Oops, forgot to discard that comment after I read
55
56 private:
57 DISALLOW_COPY_AND_ASSIGN(TaskSchedulerSequenceTest);
58 };
59
60 void ExpectSortKey(TaskPriority expected_priority,
61 TimeTicks expected_sequenced_time,
62 const SequenceSortKey& actual_sort_key) {
63 EXPECT_EQ(expected_priority, actual_sort_key.priority);
64 EXPECT_EQ(expected_sequenced_time, actual_sort_key.next_task_sequenced_time);
65 }
66
67 } // namespace
68
69 TEST_F(TaskSchedulerSequenceTest, PushPopPeek) {
70 scoped_refptr<Sequence> sequence(new Sequence);
71
72 EXPECT_TRUE(sequence->PushTask(std::move(task_a_)));
73 EXPECT_EQ(task_a_raw_, sequence->PeekTask());
74 EXPECT_FALSE(task_a_raw_->sequenced_time.is_null());
75
76 EXPECT_FALSE(sequence->PushTask(std::move(task_b_)));
77 EXPECT_EQ(task_a_raw_, sequence->PeekTask());
78 EXPECT_FALSE(task_b_raw_->sequenced_time.is_null());
79
80 EXPECT_FALSE(sequence->PushTask(std::move(task_c_)));
81 EXPECT_EQ(task_a_raw_, sequence->PeekTask());
82 EXPECT_FALSE(task_c_raw_->sequenced_time.is_null());
83
84 EXPECT_FALSE(sequence->PushTask(std::move(task_d_)));
85 EXPECT_EQ(task_a_raw_, sequence->PeekTask());
86 EXPECT_FALSE(task_d_raw_->sequenced_time.is_null());
87
88 EXPECT_FALSE(sequence->PopTask());
89 EXPECT_EQ(task_b_raw_, sequence->PeekTask());
90
91 EXPECT_FALSE(sequence->PopTask());
92 EXPECT_EQ(task_c_raw_, sequence->PeekTask());
93
94 EXPECT_FALSE(sequence->PopTask());
95 EXPECT_EQ(task_d_raw_, sequence->PeekTask());
96
97 EXPECT_FALSE(sequence->PushTask(std::move(task_e_)));
98 EXPECT_EQ(task_d_raw_, sequence->PeekTask());
99 EXPECT_FALSE(task_e_raw_->sequenced_time.is_null());
100
101 EXPECT_FALSE(sequence->PopTask());
102 EXPECT_EQ(task_e_raw_, sequence->PeekTask());
103
104 EXPECT_TRUE(sequence->PopTask());
105 EXPECT_EQ(nullptr, sequence->PeekTask());
106 }
107
108 TEST_F(TaskSchedulerSequenceTest, GetSortKey) {
109 scoped_refptr<Sequence> sequence(new Sequence);
110
111 sequence->PushTask(std::move(task_a_));
112 ExpectSortKey(TaskPriority::BACKGROUND, task_a_raw_->sequenced_time,
113 sequence->GetSortKey());
114
115 sequence->PushTask(std::move(task_b_));
116 ExpectSortKey(TaskPriority::USER_VISIBLE, task_a_raw_->sequenced_time,
117 sequence->GetSortKey());
118
119 sequence->PushTask(std::move(task_c_));
120 ExpectSortKey(TaskPriority::USER_BLOCKING, task_a_raw_->sequenced_time,
121 sequence->GetSortKey());
122
123 sequence->PushTask(std::move(task_d_));
124 ExpectSortKey(TaskPriority::USER_BLOCKING, task_a_raw_->sequenced_time,
125 sequence->GetSortKey());
126
127 sequence->PopTask();
128 ExpectSortKey(TaskPriority::USER_BLOCKING, task_b_raw_->sequenced_time,
129 sequence->GetSortKey());
130
131 sequence->PopTask();
132 ExpectSortKey(TaskPriority::USER_BLOCKING, task_c_raw_->sequenced_time,
133 sequence->GetSortKey());
134
135 sequence->PopTask();
136 ExpectSortKey(TaskPriority::USER_BLOCKING, task_d_raw_->sequenced_time,
137 sequence->GetSortKey());
138
139 sequence->PushTask(std::move(task_e_));
140 ExpectSortKey(TaskPriority::USER_BLOCKING, task_d_raw_->sequenced_time,
141 sequence->GetSortKey());
142
143 sequence->PopTask();
144 ExpectSortKey(TaskPriority::BACKGROUND, task_e_raw_->sequenced_time,
145 sequence->GetSortKey());
146 }
147
148 } // namespace internal
149 } // namespace base
OLDNEW
« no previous file with comments | « base/task_scheduler/sequence_sort_key_unittest.cc ('k') | base/task_scheduler/task.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698