TaskScheduler [3/9] Task and Sequence

base/task_scheduler/test_util.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/task_scheduler/test_util.h"
+
+#include <ostream>
+
+#include "base/logging.h"
+
+namespace base {
+
+void PrintTo(const TaskPriority& task_priority, std::ostream* os) {
+  switch (task_priority) {
+    case TaskPriority::USER_BLOCKING:
+      *os << "USER_BLOCKING";
+      break;
+    case TaskPriority::USER_VISIBLE:
+      *os << "USER_VISIBLE";
+      break;
+    case TaskPriority::BACKGROUND:
+      *os << "BACKGROUND";
+      break;
+    default:

[gab, 2016/02/18 03:00:46]

No default, without the default clang compile will break if someone adds a new
TaskPriority without adjusting this :-).

In general always avoid default in switches when you can.

[fdoray, 2016/02/18 14:56:13]

Done.

[robliao, 2016/02/22 21:34:12]

https://google.github.io/styleguide/cppguide.html#Loops_and_Switch_Statements

If not conditional on an enumerated value, switch statements should always have
a default case (in the case of an enumerated value, the compiler will warn you
if any values are not handled).

Given that this is an enum, we're good to go here.

[gab, 2016/02/22 21:40:24]

Right, are we saying the same thing? I'm confused by your reply on this?

[robliao, 2016/02/22 21:45:48]

Yup. We're saying the same thing. No default required for this case.

+      NOTREACHED();
+  }
+}
+
+}  // namespace base