Use %B format instead of %s\n\n%b to get the raw commit message from a hash.

Use %B format instead of %s\n\n%b to get the raw commit message from a hash.

\n doesn't work on Windows, and %B is shorter anyway.

BUG=586344
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298845

[Bernhard Bauer, 2016-02-18 09:49:37]

bauerb@chromium.org changed reviewers:
+ scottmg@chromium.org, tandrii@chromium.org

[Bernhard Bauer, 2016-02-18 09:49:37]

Please review.

There are some more instances of %s\n\n%b in there (used e.g. for creating a CL
description from several commit messages) -- did you have any problems with
these, Scott?

[tandrii(chromium), 2016-02-18 10:03:54]

lgtm

[Bernhard Bauer, 2016-02-18 10:16:28]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2016-02-18 10:16:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1705193003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1705193003/1

[commit-bot: I haz the power, 2016-02-18 10:18:30]

Description was changed from

==========
Use %B format instead of %s\n\n%b to get the raw commit message from a hash.

\n doesn't work on Windows, and %B is shorter anyway.

BUG=586344
==========

to

==========
Use %B format instead of %s\n\n%b to get the raw commit message from a hash.

\n doesn't work on Windows, and %B is shorter anyway.

BUG=586344

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298845
==========

[commit-bot: I haz the power, 2016-02-18 10:18:31]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298845

[scottmg, 2016-02-18 18:02:48]

https://codereview.chromium.org/1705193003/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1705193003/diff/1/git_cl.py#newcode2081
git_cl.py:2081: '-m', message]).strip()
Will message still be multiline? I think this will end up only getting the first
line still.

[Bernhard Bauer, 2016-02-18 20:12:18]

https://codereview.chromium.org/1705193003/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1705193003/diff/1/git_cl.py#newcode2081
git_cl.py:2081: '-m', message]).strip()
On 2016/02/18 18:02:48, scottmg wrote:
> Will message still be multiline? I think this will end up only getting the
first
> line still.

Dunno… is that different on Windows? I could imagine that things are different
now that we are going to have the real commit message, not the one with \n after
the first line. But really… would you mind just testing it? :)