Activate memory reducer for small heaps in background tabs.

Activate memory reducer for small heaps in background tabs.

BUG=chromium:587574
LOG=NO

Committed: https://crrev.com/b238864d0e0531be63f0e54dfcb1b5bec2e9d622
Cr-Commit-Position: refs/heads/master@{#34188}

[ulan, 2016-02-22 09:30:47]

Description was changed from

==========
Activate memory reducer for small heaps in background tabs.

BUG=
==========

to

==========
Activate memory reducer for small heaps in background tabs.

BUG=chromium:587574
LOG=NO
==========

[ulan, 2016-02-22 09:30:47]

ulan@chromium.org changed reviewers:
+ jochen@chromium.org

[ulan, 2016-02-22 09:30:55]

ptal

[jochen (gone - plz use gerrit), 2016-02-22 09:40:09]

https://codereview.chromium.org/1705183003/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1705183003/diff/20001/src/heap/heap.cc#newcod...
src/heap/heap.cc:4116: // 2 pages for each old generation space + 1 page for new
space.
that's lo_space and old_space and?

https://codereview.chromium.org/1705183003/diff/20001/src/heap/heap.cc#newcod...
src/heap/heap.cc:4118: if (ms_count_ == 0 && CommittedMemory() >
kMinCommittedMemory) {
I guess this method is invoked every time a tab goes to the background?

[ulan, 2016-02-22 10:05:32]

https://codereview.chromium.org/1705183003/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1705183003/diff/20001/src/heap/heap.cc#newcod...
src/heap/heap.cc:4116: // 2 pages for each old generation space + 1 page for new
space.
On 2016/02/22 09:40:09, jochen wrote:
> that's lo_space and old_space and?

Expanded the comment. It is old, code, and map space. For small heaps lo space
should be close to 0.

https://codereview.chromium.org/1705183003/diff/20001/src/heap/heap.cc#newcod...
src/heap/heap.cc:4118: if (ms_count_ == 0 && CommittedMemory() >
kMinCommittedMemory) {
On 2016/02/22 09:40:09, jochen wrote:
> I guess this method is invoked every time a tab goes to the background?

yes

[jochen (gone - plz use gerrit), 2016-02-22 10:06:51]

lgtm

[ulan, 2016-02-22 10:18:13]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2016-02-22 10:18:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1705183003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1705183003/60001

[commit-bot: I haz the power, 2016-02-22 10:52:29]

Description was changed from

==========
Activate memory reducer for small heaps in background tabs.

BUG=chromium:587574
LOG=NO
==========

to

==========
Activate memory reducer for small heaps in background tabs.

BUG=chromium:587574
LOG=NO
==========

[commit-bot: I haz the power, 2016-02-22 10:52:30]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-22 10:52:41]

Description was changed from

==========
Activate memory reducer for small heaps in background tabs.

BUG=chromium:587574
LOG=NO
==========

to

==========
Activate memory reducer for small heaps in background tabs.

BUG=chromium:587574
LOG=NO

Committed: https://crrev.com/b238864d0e0531be63f0e54dfcb1b5bec2e9d622
Cr-Commit-Position: refs/heads/master@{#34188}
==========

[commit-bot: I haz the power, 2016-02-22 10:52:42]

Patchset 4 (id:??) landed as
https://crrev.com/b238864d0e0531be63f0e54dfcb1b5bec2e9d622
Cr-Commit-Position: refs/heads/master@{#34188}