Move native entry argument exception throwing code out of line

Move native entry argument exception throwing code out of line

Also, disable tracing of natives and runtime calls in product mode.

(stripped) dart_product before: 5385712
(stripped) dart_product after: 5307888

Reduction in size: 77824 bytes.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/7fbeb82a4caf5020cf5f9e2a29fb53ebffe06022

[Cutch, 2016-02-18 14:56:12]

Description was changed from

==========
Move native entry argument exception throwing code out of line

BUG=
==========

to

==========
Move native entry argument exception throwing code out of line


(stripped) dart_product before: 5385712
(stripped) dart_product after: 5316080

Reduction in size: 69632 bytes.
==========

[Cutch, 2016-02-18 14:56:12]

johnmccutchan@google.com changed reviewers:
+ asiva@google.com

[Cutch, 2016-02-18 15:29:51]

Description was changed from

==========
Move native entry argument exception throwing code out of line


(stripped) dart_product before: 5385712
(stripped) dart_product after: 5316080

Reduction in size: 69632 bytes.
==========

to

==========
Move native entry argument exception throwing code out of line

Also, disable tracing of natives and runtime calls in product mode.

(stripped) dart_product before: 5385712
(stripped) dart_product after: 5307888

Reduction in size: 77824 bytes.
==========

[siva, 2016-02-18 16:55:22]

lgtm

https://codereview.chromium.org/1705163003/diff/20001/runtime/vm/native_entry.h
File runtime/vm/native_entry.h (right):

https://codereview.chromium.org/1705163003/diff/20001/runtime/vm/native_entry...
runtime/vm/native_entry.h:99: name ^= value;
Not sure why we did it this way and not as:

const type& name = type::Handle(zone, value);

[Cutch, 2016-02-18 17:04:00]

Description was changed from

==========
Move native entry argument exception throwing code out of line

Also, disable tracing of natives and runtime calls in product mode.

(stripped) dart_product before: 5385712
(stripped) dart_product after: 5307888

Reduction in size: 77824 bytes.
==========

to

==========
Move native entry argument exception throwing code out of line

Also, disable tracing of natives and runtime calls in product mode.

(stripped) dart_product before: 5385712
(stripped) dart_product after: 5307888

Reduction in size: 77824 bytes.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7fbeb82a4caf5020cf5f9e2a29fb53ebffe06022
==========

[Cutch, 2016-02-18 17:04:01]

Committed patchset #2 (id:20001) manually as
7fbeb82a4caf5020cf5f9e2a29fb53ebffe06022 (presubmit successful).

[Cutch, 2016-02-18 17:04:41]

https://codereview.chromium.org/1705163003/diff/20001/runtime/vm/native_entry.h
File runtime/vm/native_entry.h (right):

https://codereview.chromium.org/1705163003/diff/20001/runtime/vm/native_entry...
runtime/vm/native_entry.h:99: name ^= value;
On 2016/02/18 16:55:22, siva wrote:
> Not sure why we did it this way and not as:
> 
> const type& name = type::Handle(zone, value);

That doesn't compile without first doing a RawCast on value.

[siva, 2016-05-27 23:47:24]

https://chromiumcodereview.appspot.com/1705163003/diff/20001/runtime/vm/nativ...
File runtime/vm/native_entry.h (right):

https://chromiumcodereview.appspot.com/1705163003/diff/20001/runtime/vm/nativ...
runtime/vm/native_entry.h:99: name ^= value;
On 2016/02/18 17:04:41, Cutch wrote:
> On 2016/02/18 16:55:22, siva wrote:
> > Not sure why we did it this way and not as:
> > 
> > const type& name = type::Handle(zone, value);
> 
> That doesn't compile without first doing a RawCast on value.

Got it.