Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1705123004: Fix styleguide violations from https://codereview.chromium.org/1681363003 (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
Reviewers:
jbroman
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix styleguide violations from https://codereview.chromium.org/1681363003 * Don't use default capture (luckily not needed here) * Don't use std::function -- since nothing's captured, the lambda can decay to a function pointer here No behavior change. BUG=none Committed: https://crrev.com/08feeb7e4150acb4dd1af413555023660682c3c8 Cr-Commit-Position: refs/heads/master@{#375990}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M tools/gn/command_help.cc View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Nico
4 years, 10 months ago (2016-02-17 20:43:28 UTC) #3
jbroman
lgtm
4 years, 10 months ago (2016-02-17 20:58:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705123004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705123004/1
4 years, 10 months ago (2016-02-17 21:01:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 21:52:25 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 21:55:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08feeb7e4150acb4dd1af413555023660682c3c8
Cr-Commit-Position: refs/heads/master@{#375990}

Powered by Google App Engine
This is Rietveld 408576698