Add batch information to json

Add batch information to json

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1705093002

Committed: https://skia.googlesource.com/skia/+/6b3cf73af525fdbf6fd093304db840bb998e3dd6

[joshua.litt, 2016-02-17 15:25:58]

Description was changed from

==========
Add batch information to json

BUG=skia:
==========

to

==========
Add batch information to json

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-02-17 15:51:50]

joshualitt@google.com changed reviewers:
+ ethannicholas@google.com, jcgregorio@google.com, joshualitt@google.com

[joshualitt, 2016-02-17 15:51:50]

I'm open to other ways of doing this.  I just chose the most expedient method.

This might return slightly different batches from drawTo, but its gotta be
pretty close.  I can fix that in a follow on.

[ethannicholas, 2016-02-17 16:16:07]

https://codereview.chromium.org/1705093002/diff/40001/tools/debugger/SkDrawCo...
File tools/debugger/SkDrawCommand.cpp (right):

https://codereview.chromium.org/1705093002/diff/40001/tools/debugger/SkDrawCo...
tools/debugger/SkDrawCommand.cpp:230: if (canvas) {
Why is the canvas to draw to optional in a method named "drawTo"?

https://codereview.chromium.org/1705093002/diff/40001/tools/debugger/SkDrawCo...
tools/debugger/SkDrawCommand.cpp:246: result["batches"] = parsedFromString;
Could we define a SKDEBUGCANVAS_ATTRIBUTE_BATCHES constant to match the usage
elsewhere?

https://codereview.chromium.org/1705093002/diff/40001/tools/debugger/SkDrawCo...
tools/debugger/SkDrawCommand.cpp:247: at->reset();
Resetting the auditor in between every single draw command doesn't interfere
with anything? Meaning we draw a rect, and say it's in batch 6. Then we reset,
and draw another rect... and the auditor correctly says it's in batch 6 as well?

[joshualitt, 2016-02-17 16:31:02]

feedback incorporated.

https://codereview.chromium.org/1705093002/diff/40001/tools/debugger/SkDrawCo...
File tools/debugger/SkDrawCommand.cpp (right):

https://codereview.chromium.org/1705093002/diff/40001/tools/debugger/SkDrawCo...
tools/debugger/SkDrawCommand.cpp:230: if (canvas) {
On 2016/02/17 16:16:07, ethannicholas wrote:
> Why is the canvas to draw to optional in a method named "drawTo"?

Acknowledged.

https://codereview.chromium.org/1705093002/diff/40001/tools/debugger/SkDrawCo...
tools/debugger/SkDrawCommand.cpp:246: result["batches"] = parsedFromString;
On 2016/02/17 16:16:07, ethannicholas wrote:
> Could we define a SKDEBUGCANVAS_ATTRIBUTE_BATCHES constant to match the usage
> elsewhere?

Acknowledged.

https://codereview.chromium.org/1705093002/diff/40001/tools/debugger/SkDrawCo...
tools/debugger/SkDrawCommand.cpp:247: at->reset();
On 2016/02/17 16:16:07, ethannicholas wrote:
> Resetting the auditor in between every single draw command doesn't interfere
> with anything? Meaning we draw a rect, and say it's in batch 6. Then we reset,
> and draw another rect... and the auditor correctly says it's in batch 6 as
well?

discussed offline

[ethannicholas, 2016-02-17 16:50:30]

lgtm

[joshualitt, 2016-02-17 16:56:11]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2016-02-17 16:56:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1705093002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1705093002/60001

[commit-bot: I haz the power, 2016-02-17 16:57:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 16:57:45]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[joshualitt, 2016-02-17 17:13:07]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2016-02-17 17:13:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
ethannicholas@google.com
Link to the patchset: https://codereview.chromium.org/1705093002/#ps80001
(title: "fix cpu bot")

[commit-bot: I haz the power, 2016-02-17 17:13:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1705093002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1705093002/80001

[commit-bot: I haz the power, 2016-02-17 17:19:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 17:19:59]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)

[joshualitt, 2016-02-17 18:06:20]

Patchset #6 (id:100001) has been deleted

[joshualitt, 2016-02-17 18:56:44]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2016-02-17 18:56:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
ethannicholas@google.com
Link to the patchset: https://codereview.chromium.org/1705093002/#ps80001
(title: "fix cpu bot")

[commit-bot: I haz the power, 2016-02-17 18:56:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1705093002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1705093002/80001

[commit-bot: I haz the power, 2016-02-17 19:20:29]

Description was changed from

==========
Add batch information to json

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add batch information to json

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/6b3cf73af525fdbf6fd093304db840bb998e3dd6
==========

[commit-bot: I haz the power, 2016-02-17 19:20:30]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/6b3cf73af525fdbf6fd093304db840bb998e3dd6