CodeStubAssembler can generate code for builtins

src/compiler/code-stub-assembler.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_CODE_STUB_ASSEMBLER_H_
 #define V8_COMPILER_CODE_STUB_ASSEMBLER_H_
 
 #include <map>
 
 // Clients of this interface shouldn't depend on lots of compiler internals.
@@ skipping 25 matching lines @@
 #define CODE_STUB_ASSEMBLER_BINARY_OP_LIST(V) \
   V(Float64Equal)                             \
   V(Float64LessThan)                          \
   V(Float64LessThanOrEqual)                   \
   V(IntPtrAdd)                                \
   V(IntPtrSub)                                \
   V(Int32Add)                                 \
   V(Int32Sub)                                 \
   V(Int32Mul)                                 \
   V(Int32GreaterThanOrEqual)                  \
+  V(Int32LessThan)                            \
   V(WordEqual)                                \
   V(WordNotEqual)                             \
   V(WordOr)                                   \
   V(WordAnd)                                  \
   V(WordXor)                                  \
   V(WordShl)                                  \
   V(WordShr)                                  \
   V(WordSar)                                  \
   V(WordRor)                                  \
   V(Word32Equal)                              \
   V(Word32NotEqual)                           \
   V(Word32Or)                                 \
   V(Word32And)                                \
   V(Word32Xor)                                \
   V(Word32Shl)                                \
   V(Word32Shr)                                \
   V(Word32Sar)                                \
   V(Word32Ror)                                \
   V(Word64Equal)                              \
   V(Word64NotEqual)                           \
   V(Word64Or)                                 \
   V(Word64And)                                \
   V(Word64Xor)                                \
   V(Word64Shr)                                \
   V(Word64Sar)                                \
   V(Word64Ror)                                \
   V(UintPtrGreaterThanOrEqual)
 
+#define CODE_STUB_ASSEMBLER_UNARY_OP_LIST(V) \
+  V(ChangeFloat64ToUint32)                   \
+  V(ChangeInt32ToInt64)                      \
+  V(ChangeUint32ToFloat64)
+
 class CodeStubAssembler {
  public:
+  // Create with CallStub linkage.
   // |result_size| specifies the number of results returned by the stub.
   // TODO(rmcilroy): move result_size to the CallInterfaceDescriptor.
   CodeStubAssembler(Isolate* isolate, Zone* zone,
                     const CallInterfaceDescriptor& descriptor,
                     Code::Flags flags, const char* name,
                     size_t result_size = 1);
+
+  // Create with JSCall linkage.
+  CodeStubAssembler(Isolate* isolate, Zone* zone, int parameter_count,
+                    Code::Flags flags, const char* name);
+
   virtual ~CodeStubAssembler();
 
   Handle<Code> GenerateCode();
 
   class Label;
   class Variable {
    public:
     explicit Variable(CodeStubAssembler* assembler, MachineRepresentation rep);
     void Bind(Node* value);
     Node* value() const;
@@ skipping 49 matching lines @@
                             Node* value);
 
 // Basic arithmetic operations.
 #define DECLARE_CODE_STUB_ASSEMBER_BINARY_OP(name) Node* name(Node* a, Node* b);
   CODE_STUB_ASSEMBLER_BINARY_OP_LIST(DECLARE_CODE_STUB_ASSEMBER_BINARY_OP)
 #undef DECLARE_CODE_STUB_ASSEMBER_BINARY_OP
 
   Node* WordShl(Node* value, int shift);
 
   // Conversions
-  Node* ChangeInt32ToInt64(Node* value);
+#define DECLARE_CODE_STUB_ASSEMBER_UNARY_OP(name) Node* name(Node* a);
+  CODE_STUB_ASSEMBLER_UNARY_OP_LIST(DECLARE_CODE_STUB_ASSEMBER_UNARY_OP)
+#undef DECLARE_CODE_STUB_ASSEMBER_UNARY_OP
 
   // Projections
   Node* Projection(int index, Node* value);
 
   // Calls
   Node* CallRuntime(Runtime::FunctionId function_id, Node* context);
   Node* CallRuntime(Runtime::FunctionId function_id, Node* context, Node* arg1);
   Node* CallRuntime(Runtime::FunctionId function_id, Node* context, Node* arg1,
                     Node* arg2);
   Node* CallRuntime(Runtime::FunctionId function_id, Node* context, Node* arg1,
                     Node* arg2, Node* arg3);
   Node* CallRuntime(Runtime::FunctionId function_id, Node* context, Node* arg1,
                     Node* arg2, Node* arg3, Node* arg4);
   Node* CallRuntime(Runtime::FunctionId function_id, Node* context, Node* arg1,
                     Node* arg2, Node* arg3, Node* arg4, Node* arg5);
 
+  Node* TailCallRuntime(Runtime::FunctionId function_id, Node* context);
   Node* TailCallRuntime(Runtime::FunctionId function_id, Node* context,
                         Node* arg1);
   Node* TailCallRuntime(Runtime::FunctionId function_id, Node* context,
                         Node* arg1, Node* arg2);
   Node* TailCallRuntime(Runtime::FunctionId function_id, Node* context,
                         Node* arg1, Node* arg2, Node* arg3);
   Node* TailCallRuntime(Runtime::FunctionId function_id, Node* context,
                         Node* arg1, Node* arg2, Node* arg3, Node* arg4);
 
   Node* CallStub(const CallInterfaceDescriptor& descriptor, Node* target,
@@ skipping 11 matching lines @@
                  Node* arg5, size_t result_size = 1);
 
   Node* TailCallStub(CodeStub& stub, Node** args);
   Node* TailCall(const CallInterfaceDescriptor& descriptor, Node* target,
                  Node** args, size_t result_size = 1);
 
   // ===========================================================================
   // Macros
   // ===========================================================================
 
-  // Tag and untag Smi values.
+  // Tag a Word as a Smi value.
   Node* SmiTag(Node* value);
+  // Untag a Smi value as a Word.
   Node* SmiUntag(Node* value);
+  // Untag an Smi value as a 32-bit value.
+  Node* SmiUntag32(Node* value);

[Benedikt Meurer, 2016/03/01 04:54:44]

Nit: Rename to SmiToInt32

[binji, 2016/03/01 21:56:38]

Done.

 
   // Smi operations.
   Node* SmiAdd(Node* a, Node* b);
   Node* SmiEqual(Node* a, Node* b);
 
   // Load a value from the root array.
   Node* LoadRoot(Heap::RootListIndex root_index);
 
   // Check a value for smi-ness
   Node* WordIsSmi(Node* a);
 
   // Load an object pointer from a buffer that isn't in the heap.
   Node* LoadBufferObject(Node* buffer, int offset);
   // Load a field from an object on the heap.
   Node* LoadObjectField(Node* object, int offset);
+  // Load the HeapNumber value from a HeapNumber object.
+  Node* LoadHeapNumber(Node* object);

[Benedikt Meurer, 2016/03/01 04:54:44]

Nit: Rename to LoadHeapNumberValue

[binji, 2016/03/01 21:56:38]

Done.

 
   // Load an array element from a FixedArray.
   Node* LoadFixedArrayElementSmiIndex(Node* object, Node* smi_index,
                                       int additional_offset = 0);
   Node* LoadFixedArrayElementConstantIndex(Node* object, int index);
 
+  Node* InstanceType(Node* object);

[Jarin, 2016/02/29 20:04:43]

InstanceType -> LoadInstanceType?

[binji, 2016/03/01 21:56:38]

Done.

+
+  // Returns a node that is true if the given bit is set in |word32|.
+  template <typename T>
+  Node* BitFieldValue(Node* word32) {

[Benedikt Meurer, 2016/03/01 04:54:44]

Nit: Rename to BitFieldDecode

[binji, 2016/03/01 21:56:38]

Done.

+    return BitFieldValue(word32, T::kShift, T::kMask);
+  }
+
+  Node* BitFieldValue(Node* word32, uint32_t shift, uint32_t mask);

[Benedikt Meurer, 2016/03/01 04:54:44]

Nit: Rename to BitFieldDecode

[binji, 2016/03/01 21:56:38]

Done.

+
  protected:
   // Protected helpers which delegate to RawMachineAssembler.
   Graph* graph();
   Isolate* isolate();
   Zone* zone();
 
   // Enables subclasses to perform operations before and after a call.
   virtual void CallPrologue();
   virtual void CallEpilogue();
 
@@ skipping 39 matching lines @@
   // Map of variables to the list of value nodes that have been added from each
   // merge path in their order of merging.
   std::map<Variable::Impl*, std::vector<Node*>> variable_merges_;
 };
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_CODE_STUB_ASSEMBLER_H_