Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1215)

Issue 1705063002: bin/sync-and-gyp: pass --deps='...' to `gclient sync`. (Closed)

Created:
4 years, 10 months ago by hal.canary
Modified:
4 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : 2016-02-17 (Wednesday) 11:02:32 EST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M bin/sync-and-gyp View 1 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
hal.canary
PTAL preparation for splitting DEPS.
4 years, 10 months ago (2016-02-17 15:12:45 UTC) #4
mtklein
I know you wrote down in the docs that this script is the way to ...
4 years, 10 months ago (2016-02-17 15:16:04 UTC) #5
mtklein
lgtm https://codereview.chromium.org/1705063002/diff/1/bin/sync-and-gyp File bin/sync-and-gyp (right): https://codereview.chromium.org/1705063002/diff/1/bin/sync-and-gyp#newcode84 bin/sync-and-gyp:84: sys.stdout.write(' '.join(gclient_sync_command) + '\n') Might be nicer to ...
4 years, 10 months ago (2016-02-17 15:18:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705063002/1
4 years, 10 months ago (2016-02-17 16:03:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705063002/40001
4 years, 10 months ago (2016-02-17 16:05:42 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 16:39:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/117672db3f6affd60a4a30c5110f54ca6b095aa5

Powered by Google App Engine
This is Rietveld 408576698