Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1705013002: Add comment to use counter def, so it doesn't constantly get out of sync (Closed)

Created:
4 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 10 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add comment to use counter def, so it doesn't constantly get out of sync R=adamk@chromium.org BUG= Committed: https://crrev.com/f0090eee1224c2d421a4bf893ea39864ee14b4b3 Cr-Commit-Position: refs/heads/master@{#34101}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M include/v8.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jochen (gone - plz use gerrit)
4 years, 10 months ago (2016-02-17 14:20:25 UTC) #1
adamk
lgtm, though I don't think the lack of a comment here is the reason it ...
4 years, 10 months ago (2016-02-17 18:56:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705013002/20001
4 years, 10 months ago (2016-02-18 07:32:44 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-18 08:05:22 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 08:06:16 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f0090eee1224c2d421a4bf893ea39864ee14b4b3
Cr-Commit-Position: refs/heads/master@{#34101}

Powered by Google App Engine
This is Rietveld 408576698