Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: test/unittests/interpreter/source-position-table-unittest.cc

Issue 1704943002: Encode interpreter::SourcePositionTable as variable-length ints. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix multi-revert case & add test. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/unittests/interpreter/source-position-table-unittest.cc
diff --git a/test/unittests/interpreter/source-position-table-unittest.cc b/test/unittests/interpreter/source-position-table-unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..2e3021ae8d148429f5810601d37f288246eeb6b9
--- /dev/null
+++ b/test/unittests/interpreter/source-position-table-unittest.cc
@@ -0,0 +1,111 @@
+// Copyright 2016 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "src/v8.h"
+
+#include "src/interpreter/source-position-table.h"
+#include "test/unittests/test-utils.h"
+
+namespace v8 {
+namespace internal {
+namespace interpreter {
+
+class SourcePositionTableTest : public TestWithIsolateAndZone {
+ public:
+ SourcePositionTableTest() {}
+ ~SourcePositionTableTest() override {}
+};
+
+// Some random offsets, mostly at 'suspicious' bit boundaries.
+static int offsets[] = {0, 1, 2, 3, 4, 30, 31, 32,
+ 33, 62, 63, 64, 65, 126, 127, 128,
+ 129, 250, 1000, 9999, 12000, 31415926};
+
+TEST_F(SourcePositionTableTest, EncodeStatement) {
+ SourcePositionTableBuilder builder(isolate(), zone());
+ for (int i = 0; i < arraysize(offsets); i++) {
+ builder.AddStatementPosition(offsets[i], offsets[i]);
+ }
+
+ // To test correctness, we rely on the assertions in ToSourcePositionTable().
+ // (Also below.)
+ CHECK(!builder.ToSourcePositionTable().is_null());
+}
+
+TEST_F(SourcePositionTableTest, EncodeExpression) {
+ SourcePositionTableBuilder builder(isolate(), zone());
+ for (int i = 0; i < arraysize(offsets); i++) {
+ builder.AddExpressionPosition(offsets[i], offsets[i]);
+ }
+ CHECK(!builder.ToSourcePositionTable().is_null());
+}
+
+TEST_F(SourcePositionTableTest, EncodeAscending) {
+ SourcePositionTableBuilder builder(isolate(), zone());
+
+ int accumulator = 0;
+ for (int i = 0; i < arraysize(offsets); i++) {
+ accumulator += offsets[i];
+ if (i % 2) {
+ builder.AddStatementPosition(accumulator, accumulator);
+ } else {
+ builder.AddExpressionPosition(accumulator, accumulator);
+ }
+ }
+
+ // Also test negative offsets:
+ for (int i = 0; i < arraysize(offsets); i++) {
+ accumulator -= offsets[i];
+ if (i % 2) {
+ builder.AddStatementPosition(accumulator, accumulator);
+ } else {
+ builder.AddExpressionPosition(accumulator, accumulator);
+ }
+ }
+
+ CHECK(!builder.ToSourcePositionTable().is_null());
+}
+
+TEST_F(SourcePositionTableTest, EncodeRevert) {
+ SourcePositionTableBuilder builder(isolate(), zone());
+
+ int accumulator = 0;
+ for (int i = 0; i < arraysize(offsets); i++) {
+ accumulator += offsets[i];
+ builder.AddStatementPosition(accumulator, accumulator);
+
+ // Every other position is reverted. Among these, every other position
+ // is reverted with the same bytecode offset.
+ if (i % 4 == 1) {
+ builder.RevertPosition(accumulator);
+ } else if (i % 4 == 3) {
+ builder.RevertPosition(accumulator + 1);
+ }
+ }
+
+ CHECK(!builder.ToSourcePositionTable().is_null());
+}
+
+TEST_F(SourcePositionTableTest, MultiRevert) {
+ SourcePositionTableBuilder builder(isolate(), zone());
+ builder.AddStatementPosition(1, 3);
+ builder.AddStatementPosition(12, 34);
+
+ // There can be many reverts for the same position, before or after
+ // that position is actually added. Only one of them should do something.
+ builder.RevertPosition(101);
+ builder.RevertPosition(101);
+ builder.RevertPosition(101);
+ builder.AddStatementPosition(101, 55);
+ builder.RevertPosition(101);
+ builder.RevertPosition(101);
+ builder.RevertPosition(101);
+
+ builder.AddStatementPosition(314, 1529);
+ CHECK(!builder.ToSourcePositionTable().is_null());
+}
+
+} // namespace interpreter
+} // namespace internal
+} // namespace v8

Powered by Google App Engine
This is Rietveld 408576698