Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1704933002: Increase minimum iOS version requirements to iOS 9.0. (Closed)

Created:
4 years, 10 months ago by sdefresne
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increase minimum iOS version requirements to iOS 9.0. Chrome on iOS requires iOS 9.0 as it uses WKWebView (and the version from iOS 8.0 lacks some required features). Increate the minimum iOS version in build/common.gypi. BUG=569158 Committed: https://crrev.com/77193364a92ca0636fe8774ce6e37bedff9bbf88 Cr-Commit-Position: refs/heads/master@{#375862}

Patch Set 1 #

Patch Set 2 : Also increase the ios_deployment_target when using GN for the build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/config/ios/ios_sdk.gni View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sdefresne
thakis: Please review as OWNERS. Note that this has been true for a few weeks ...
4 years, 10 months ago (2016-02-17 11:05:08 UTC) #2
Nico
lgtm
4 years, 10 months ago (2016-02-17 11:31:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704933002/20001
4 years, 10 months ago (2016-02-17 12:03:54 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 12:34:47 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 12:35:50 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/77193364a92ca0636fe8774ce6e37bedff9bbf88
Cr-Commit-Position: refs/heads/master@{#375862}

Powered by Google App Engine
This is Rietveld 408576698