Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1704913002: [interpreter] Remove CompilationInfo from graph builder. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_strong-remove-3
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Remove CompilationInfo from graph builder. This removes the CompilationInfo field from the BytecodeGraphBuilder class. The intention is to reduce the risk of using uninitialized or unavailable values from the CompilationInfo (e.g. values that are only available after parsing). R=rmcilroy@chromium.org Committed: https://crrev.com/0dc896c4ef8345942370babcd079521c3852967f Cr-Commit-Position: refs/heads/master@{#34081}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -23 lines) Patch
M src/compiler/bytecode-graph-builder.h View 4 chunks +8 lines, -10 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 8 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
4 years, 10 months ago (2016-02-17 09:31:00 UTC) #1
rmcilroy
LGTM.
4 years, 10 months ago (2016-02-17 11:05:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704913002/20001
4 years, 10 months ago (2016-02-17 14:08:57 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 14:10:21 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 14:11:05 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0dc896c4ef8345942370babcd079521c3852967f
Cr-Commit-Position: refs/heads/master@{#34081}

Powered by Google App Engine
This is Rietveld 408576698