Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1704883002: Enable CSS column-fill by default (in stable). (Closed)

Created:
4 years, 10 months ago by mstensho (USE GERRIT)
Modified:
4 years, 10 months ago
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable CSS column-fill by default (in stable). There are already plenty of tests for this in LayoutTests/fast/multicol/ BUG=492297 Committed: https://crrev.com/48bd6702b137cdcddd2df1676bafa592fb8be0cd Cr-Commit-Position: refs/heads/master@{#376167}

Patch Set 1 #

Patch Set 2 : Update LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
mstensho (USE GERRIT)
This is the second patch in a series of three, which will unprefix multicol. https://groups.google.com/a/chromium.org/d/msg/blink-dev/8P5RWP_nRTk/CSQlukIACwAJ ...
4 years, 10 months ago (2016-02-18 10:24:51 UTC) #2
mstensho (USE GERRIT)
And with that, I also need an approval from an API owner. If Hanoi hasn't ...
4 years, 10 months ago (2016-02-18 13:53:37 UTC) #4
philipj_slow
lgtm Hanoi never sleeps!
4 years, 10 months ago (2016-02-18 14:40:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704883002/20001
4 years, 10 months ago (2016-02-18 14:41:36 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-18 15:14:37 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/48bd6702b137cdcddd2df1676bafa592fb8be0cd Cr-Commit-Position: refs/heads/master@{#376167}
4 years, 10 months ago (2016-02-18 15:15:58 UTC) #10
leviw_travelin_and_unemployed
4 years, 10 months ago (2016-02-18 20:47:50 UTC) #11
Message was sent while issue was closed.
Squeeee!

Powered by Google App Engine
This is Rietveld 408576698