[crankshaft] Make sure +x is as fast as Number(x).

[crankshaft] Make sure +x is as fast as Number(x).

R=yangguo@chromium.org

Committed: https://crrev.com/159ffcc0803ff41f7ede7b10f75769860dd784e8
Cr-Commit-Position: refs/heads/master@{#34057}

[Benedikt Meurer, 2016-02-17 06:32:33]

Hey Yang,

Here's the fix for the recent Docs regression in JSCompiler. It's actually quite
simple.
Please take a look.

Thanks,
Benedikt

[Benedikt Meurer, 2016-02-17 06:32:33]

Hey Yang,

Here's the fix for the recent Docs regression in JSCompiler. It's actually quite
simple.
Please take a look.

Thanks,
Benedikt

[Yang, 2016-02-17 06:34:52]

On 2016/02/17 06:32:33, Benedikt Meurer wrote:
> Hey Yang,
> 
> Here's the fix for the recent Docs regression in JSCompiler. It's actually
quite
> simple.
> Please take a look.
> 
> Thanks,
> Benedikt

lgtm

[Benedikt Meurer, 2016-02-17 06:37:52]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-02-17 06:38:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1704833002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1704833002/1

[commit-bot: I haz the power, 2016-02-17 07:41:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-17 07:42:05]

Description was changed from

==========
[crankshaft] Make sure +x is as fast as Number(x).

R=yangguo@chromium.org
==========

to

==========
[crankshaft] Make sure +x is as fast as Number(x).

R=yangguo@chromium.org

Committed: https://crrev.com/159ffcc0803ff41f7ede7b10f75769860dd784e8
Cr-Commit-Position: refs/heads/master@{#34057}
==========

[commit-bot: I haz the power, 2016-02-17 07:42:05]

Patchset 1 (id:??) landed as
https://crrev.com/159ffcc0803ff41f7ede7b10f75769860dd784e8
Cr-Commit-Position: refs/heads/master@{#34057}

[Jakob Kummerow, 2016-03-02 15:06:17]

jkummerow@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Jakob Kummerow, 2016-03-02 15:06:18]

https://codereview.chromium.org/1704833002/diff/1/src/crankshaft/hydrogen.cc
File src/crankshaft/hydrogen.cc (right):

https://codereview.chromium.org/1704833002/diff/1/src/crankshaft/hydrogen.cc#...
src/crankshaft/hydrogen.cc:11159: return BuildToNumber(right, right_type);
You can't trust |right_type| and |left_type| at this point because they may have
been modified by the calls in lines 11071/11072 above. So |BuildToNumber()| will
erroneously take the |input_type->Is(Type::Number())| branch and not do anything
(see crbug.com/590989).

[Benedikt Meurer, 2016-03-02 18:35:23]

https://codereview.chromium.org/1704833002/diff/1/src/crankshaft/hydrogen.cc
File src/crankshaft/hydrogen.cc (right):

https://codereview.chromium.org/1704833002/diff/1/src/crankshaft/hydrogen.cc#...
src/crankshaft/hydrogen.cc:11159: return BuildToNumber(right, right_type);
Crankshaft...